* [PATCH v1] pinctrl: intel: Drop double check for data in intel_pinctrl_probe_by_uid()
@ 2019-07-04 13:02 Andy Shevchenko
2019-07-04 13:13 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2019-07-04 13:02 UTC (permalink / raw)
To: Mika Westerberg, linux-gpio, Linus Walleij; +Cc: Andy Shevchenko
There is no need to duplicate the check which is done in the common
intel_pinctrl_probe().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index a18d6eefe672..8014c95c649f 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1421,8 +1421,6 @@ int intel_pinctrl_probe_by_uid(struct platform_device *pdev)
table = (const struct intel_pinctrl_soc_data **)id->driver_data;
data = table[pdev->id];
}
- if (!data)
- return -ENODEV;
return intel_pinctrl_probe(pdev, data);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: intel: Drop double check for data in intel_pinctrl_probe_by_uid()
2019-07-04 13:02 [PATCH v1] pinctrl: intel: Drop double check for data in intel_pinctrl_probe_by_uid() Andy Shevchenko
@ 2019-07-04 13:13 ` Mika Westerberg
2019-07-23 15:51 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2019-07-04 13:13 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, Linus Walleij
On Thu, Jul 04, 2019 at 04:02:39PM +0300, Andy Shevchenko wrote:
> There is no need to duplicate the check which is done in the common
> intel_pinctrl_probe().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: intel: Drop double check for data in intel_pinctrl_probe_by_uid()
2019-07-04 13:13 ` Mika Westerberg
@ 2019-07-23 15:51 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-07-23 15:51 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-gpio, Linus Walleij
On Thu, Jul 04, 2019 at 04:13:21PM +0300, Mika Westerberg wrote:
> On Thu, Jul 04, 2019 at 04:02:39PM +0300, Andy Shevchenko wrote:
> > There is no need to duplicate the check which is done in the common
> > intel_pinctrl_probe().
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-23 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 13:02 [PATCH v1] pinctrl: intel: Drop double check for data in intel_pinctrl_probe_by_uid() Andy Shevchenko
2019-07-04 13:13 ` Mika Westerberg
2019-07-23 15:51 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).