From: caizhaopeng@uniontech.com
To: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhangyueqian <zhangyueqian@uniontech.com>,
Zhangshuang <zhangshuang@uniontech.com>,
Hualet Wang <wangyaohua@uniontech.com>,
Zhanglei <zhanglei@uniontech.com>,
Caicai <caizhaopeng@uniontech.com>
Subject: [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq for elan touchpad.
Date: Fri, 24 Apr 2020 17:12:01 +0800 [thread overview]
Message-ID: <20200424091201.568-1-caizhaopeng@uniontech.com> (raw)
From: Caicai <caizhaopeng@uniontech.com>
I had tested two Notebook machines, the Intel i5(or amd ryzen)
with elan touchpad, and there's a probability that the touchpad
won't work after going to the S3/S4 to wake up, that it would
appear no more than 15 times. I found that there's no interrupt
to check for /proc/interrupt. It was found that the gpio
interrupt of i2c was also not on top. By adding the gpio
interrupt flags with IRQF_EARLY_RESUME, now the touchpad tested
200 + times works well.
Signed-off-by: Caicai <caizhaopeng@uniontech.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
drivers/pinctrl/pinctrl-amd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 8fb6c9668c37..a350dade6aa0 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1189,7 +1189,7 @@ static int intel_gpio_probe(struct intel_pinctrl *pctrl, int irq)
* controllers share the same interrupt line.
*/
ret = devm_request_irq(pctrl->dev, irq, intel_gpio_irq,
- IRQF_SHARED | IRQF_NO_THREAD,
+ IRQF_SHARED | IRQF_NO_THREAD | IRQF_EARLY_RESUME,
dev_name(pctrl->dev), pctrl);
if (ret) {
dev_err(pctrl->dev, "failed to request interrupt\n");
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 977792654e01..70c37f4da2b1 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -937,7 +937,7 @@ static int amd_gpio_probe(struct platform_device *pdev)
}
ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler,
- IRQF_SHARED, KBUILD_MODNAME, gpio_dev);
+ IRQF_SHARED | IRQF_EARLY_RESUME | IRQF_NO_THREAD, KBUILD_MODNAME, gpio_dev);
if (ret)
goto out2;
--
2.20.1
next reply other threads:[~2020-04-24 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:12 caizhaopeng [this message]
2020-04-24 9:50 ` [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq for elan touchpad Andy Shevchenko
2020-11-12 13:52 ` Andy Shevchenko
2020-11-23 12:46 ` Hans de Goede
2020-11-23 13:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424091201.568-1-caizhaopeng@uniontech.com \
--to=caizhaopeng@uniontech.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wangyaohua@uniontech.com \
--cc=zhanglei@uniontech.com \
--cc=zhangshuang@uniontech.com \
--cc=zhangyueqian@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).