From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: caizhaopeng@uniontech.com
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Zhangyueqian <zhangyueqian@uniontech.com>,
Zhangshuang <zhangshuang@uniontech.com>,
Hualet Wang <wangyaohua@uniontech.com>,
Zhanglei <zhanglei@uniontech.com>
Subject: Re: [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq for elan touchpad.
Date: Fri, 24 Apr 2020 12:50:30 +0300 [thread overview]
Message-ID: <CAHp75VekvqHX_eUm88RQJQiU59hUoxUY=pP4MWsp6xn3os9bPg@mail.gmail.com> (raw)
In-Reply-To: <20200424091201.568-1-caizhaopeng@uniontech.com>
On Fri, Apr 24, 2020 at 12:16 PM <caizhaopeng@uniontech.com> wrote:
>
> From: Caicai <caizhaopeng@uniontech.com>
>
> I had tested two Notebook machines, the Intel i5(or amd ryzen)
> with elan touchpad, and there's a probability that the touchpad
> won't work after going to the S3/S4 to wake up, that it would
> appear no more than 15 times. I found that there's no interrupt
> to check for /proc/interrupt. It was found that the gpio
> interrupt of i2c was also not on top. By adding the gpio
> interrupt flags with IRQF_EARLY_RESUME, now the touchpad tested
> 200 + times works well.
Thanks for the contribution!
You need
a) to split this to patch per driver (I can't take or speak for AMD
code, I'm not a maintainer and don't have hardware)
b) explain what this flag actually means and does
On top of that we need to test this widely to avoid regressions.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-24 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:12 [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq for elan touchpad caizhaopeng
2020-04-24 9:50 ` Andy Shevchenko [this message]
2020-11-12 13:52 ` Andy Shevchenko
2020-11-23 12:46 ` Hans de Goede
2020-11-23 13:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VekvqHX_eUm88RQJQiU59hUoxUY=pP4MWsp6xn3os9bPg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=caizhaopeng@uniontech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wangyaohua@uniontech.com \
--cc=zhanglei@uniontech.com \
--cc=zhangshuang@uniontech.com \
--cc=zhangyueqian@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).