* [PATCH 08/29] gpio: driver.h: fix kernel-doc markup
[not found] <cover.1592203542.git.mchehab+huawei@kernel.org>
@ 2020-06-15 6:46 ` Mauro Carvalho Chehab
2020-06-15 8:05 ` Bartosz Golaszewski
2020-06-15 6:46 ` [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml Mauro Carvalho Chehab
1 sibling, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2020-06-15 6:46 UTC (permalink / raw)
To: Linux Doc Mailing List
Cc: Mauro Carvalho Chehab, linux-kernel, Jonathan Corbet,
Linus Walleij, Bartosz Golaszewski, linux-gpio
There is one parameter with a wrong name at kernel-doc macro:
./include/linux/gpio/driver.h:499: warning: Function parameter or member 'gc' not described in 'gpiochip_add_data'
./include/linux/gpio/driver.h:499: warning: Excess function parameter 'chip' description in 'gpiochip_add_data'
Fix it.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
include/linux/gpio/driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index c4f272af7af5..c11261f3c724 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -481,7 +481,7 @@ extern int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
/**
* gpiochip_add_data() - register a gpio_chip
- * @chip: the chip to register, with chip->base initialized
+ * @gc: the chip to register, with chip->base initialized
* @data: driver-private data associated with this chip
*
* Context: potentially before irqs will work
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml
[not found] <cover.1592203542.git.mchehab+huawei@kernel.org>
2020-06-15 6:46 ` [PATCH 08/29] gpio: driver.h: fix kernel-doc markup Mauro Carvalho Chehab
@ 2020-06-15 6:46 ` Mauro Carvalho Chehab
2020-06-15 7:38 ` Geert Uytterhoeven
2020-06-18 16:41 ` Rob Herring
1 sibling, 2 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2020-06-15 6:46 UTC (permalink / raw)
To: Linux Doc Mailing List
Cc: Mauro Carvalho Chehab, linux-kernel, Jonathan Corbet,
Geert Uytterhoeven, Linus Walleij, Rob Herring,
Niklas Söderlund, linux-renesas-soc, linux-gpio, devicetree
This file was renamed, but its reference at pfc-pinctl.txt is
still pointing to the old file.
Fixes: 7f7d408e5a00 ("dt-bindings: gpio: rcar: Convert to json-schema")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
.../devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt
index b68613188c19..1b8e8b4a6379 100644
--- a/Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt
@@ -114,7 +114,7 @@ with values derived from the SoC user manual.
[flags]>
On other mach-shmobile platforms GPIO is handled by the gpio-rcar driver.
-Please refer to Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
+Please refer to Documentation/devicetree/bindings/gpio/renesas,rcar-gpio.yaml
for documentation of the GPIO device tree bindings on those platforms.
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml
2020-06-15 6:46 ` [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml Mauro Carvalho Chehab
@ 2020-06-15 7:38 ` Geert Uytterhoeven
2020-06-18 16:41 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-06-15 7:38 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Doc Mailing List, Linux Kernel Mailing List,
Jonathan Corbet, Geert Uytterhoeven, Linus Walleij, Rob Herring,
Niklas Söderlund, Linux-Renesas, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Mauro,
On Mon, Jun 15, 2020 at 8:47 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
> This file was renamed, but its reference at pfc-pinctl.txt is
pfc-pinctrl.txt
> still pointing to the old file.
>
> Fixes: 7f7d408e5a00 ("dt-bindings: gpio: rcar: Convert to json-schema")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thanks!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Note that the reference will go away with the pfc-pinctrl.txt json-schema
conversion.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 08/29] gpio: driver.h: fix kernel-doc markup
2020-06-15 6:46 ` [PATCH 08/29] gpio: driver.h: fix kernel-doc markup Mauro Carvalho Chehab
@ 2020-06-15 8:05 ` Bartosz Golaszewski
0 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2020-06-15 8:05 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Doc Mailing List, LKML, Jonathan Corbet, Linus Walleij, linux-gpio
pon., 15 cze 2020 o 08:47 Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> napisał(a):
>
> There is one parameter with a wrong name at kernel-doc macro:
>
> ./include/linux/gpio/driver.h:499: warning: Function parameter or member 'gc' not described in 'gpiochip_add_data'
> ./include/linux/gpio/driver.h:499: warning: Excess function parameter 'chip' description in 'gpiochip_add_data'
>
> Fix it.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> include/linux/gpio/driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index c4f272af7af5..c11261f3c724 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -481,7 +481,7 @@ extern int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
>
> /**
> * gpiochip_add_data() - register a gpio_chip
> - * @chip: the chip to register, with chip->base initialized
> + * @gc: the chip to register, with chip->base initialized
> * @data: driver-private data associated with this chip
> *
> * Context: potentially before irqs will work
> --
> 2.26.2
>
Patch applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml
2020-06-15 6:46 ` [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml Mauro Carvalho Chehab
2020-06-15 7:38 ` Geert Uytterhoeven
@ 2020-06-18 16:41 ` Rob Herring
1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-06-18 16:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Jonathan Corbet, Rob Herring, Linux Doc Mailing List, devicetree,
linux-renesas-soc, Linus Walleij, linux-gpio,
Niklas Söderlund, linux-kernel, Geert Uytterhoeven
On Mon, 15 Jun 2020 08:46:51 +0200, Mauro Carvalho Chehab wrote:
> This file was renamed, but its reference at pfc-pinctl.txt is
> still pointing to the old file.
>
> Fixes: 7f7d408e5a00 ("dt-bindings: gpio: rcar: Convert to json-schema")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> .../devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-18 16:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1592203542.git.mchehab+huawei@kernel.org>
2020-06-15 6:46 ` [PATCH 08/29] gpio: driver.h: fix kernel-doc markup Mauro Carvalho Chehab
2020-06-15 8:05 ` Bartosz Golaszewski
2020-06-15 6:46 ` [PATCH 12/29] dt: update a reference for reneases pcar file renamed to yaml Mauro Carvalho Chehab
2020-06-15 7:38 ` Geert Uytterhoeven
2020-06-18 16:41 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).