From: Sachi King <nakato@nakato.io>
To: linux-gpio@vger.kernel.org, basavaraj.natikar@amd.com
Cc: linux-kernel@vger.kernel.org, Sachi King <nakato@nakato.io>
Subject: [PATCH 0/1] pinctrl: amd: pinctrl: amd: disable and mask interrupts on probe
Date: Sat, 2 Oct 2021 02:17:13 +1000 [thread overview]
Message-ID: <20211001161714.2053597-1-nakato@nakato.io> (raw)
On a Microsoft Surface Laptop 4, I've found that the GPIO controller is
preconfigured with a number of interrupts. I'm not sure if this is
device specific, in which case I could propose a quirk, or a more
general issue. Prior to https://git.kernel.org/torvalds/c/acd47b9f28e5
which will be in 5.15, this device exhibited failed resumes that would
result in high power consumption and no reliable way to resume the
device. Following that patch the device exhibits spurious wakeups.
As far as I can tell interrupts should be disabled and masked as a
default state, so ensuring this is the initial state should be safe as a
default action.
Sachi King (1):
pinctrl: amd: disable and mask interrupts on probe
drivers/pinctrl/pinctrl-amd.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
--
2.33.0
next reply other threads:[~2021-10-01 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 16:17 Sachi King [this message]
2021-10-01 16:17 ` [PATCH 1/1] pinctrl: amd: disable and mask interrupts on probe Sachi King
2021-10-08 18:19 ` Limonciello, Mario
2021-10-09 3:42 ` Sachi King
2021-10-08 19:57 ` Basavaraj Natikar
2021-10-09 3:32 ` [PATCH v2] " Sachi King
2021-10-16 21:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001161714.2053597-1-nakato@nakato.io \
--to=nakato@nakato.io \
--cc=basavaraj.natikar@amd.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).