* [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
@ 2022-10-20 7:56 Yang Yingliang
2022-10-20 21:04 ` Richard Acayan
2022-10-24 8:19 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-10-20 7:56 UTC (permalink / raw)
To: linux-gpio; +Cc: mailingradian, linus.walleij, yangyingliang
sdm670_reserved_gpios is only used in pinctrl-sdm670.c now, change it
to static.
Fixes: 61164d220f52 ("pinctrl: qcom: add sdm670 pinctrl")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/pinctrl/qcom/pinctrl-sdm670.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sdm670.c b/drivers/pinctrl/qcom/pinctrl-sdm670.c
index 4c3c3782fef8..b888bca7ecd7 100644
--- a/drivers/pinctrl/qcom/pinctrl-sdm670.c
+++ b/drivers/pinctrl/qcom/pinctrl-sdm670.c
@@ -1294,7 +1294,7 @@ static const struct msm_pingroup sdm670_groups[] = {
SDC_QDSD_PINGROUP(sdc2_data, 0x9a000, 9, 0),
};
-const int sdm670_reserved_gpios[] = {
+static const int sdm670_reserved_gpios[] = {
58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
2022-10-20 7:56 [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static Yang Yingliang
@ 2022-10-20 21:04 ` Richard Acayan
2022-10-24 8:19 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Richard Acayan @ 2022-10-20 21:04 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-gpio, mailingradian, linus.walleij
> sdm670_reserved_gpios is only used in pinctrl-sdm670.c now, change it
> to static.
>
> Fixes: 61164d220f52 ("pinctrl: qcom: add sdm670 pinctrl")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
The email headers could maybe use a little work.
From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-gpio@vger.kernel.org>
CC: <mailingradian@gmail.com>, <linus.walleij@linaro.org>,
<yangyingliang@huawei.com>
Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
You don't need to remove people's names from their email addresses; they can go
together like so (not a strict requirement, but a nice touch in everyone's
mailboxes):
CC: Richard Acayan <mailingradian@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Yang Yingliang <yangyingliang@huawei.com>
For this patch, there is a typo in the subject:
-Subject: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
+Subject: [PATCH -next] pinctrl: qcom: sdm670: change sdm670_reserved_gpios to static
Otherwise, it looks good.
Acked-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/pinctrl/qcom/pinctrl-sdm670.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm670.c b/drivers/pinctrl/qcom/pinctrl-sdm670.c
> index 4c3c3782fef8..b888bca7ecd7 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sdm670.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sdm670.c
> @@ -1294,7 +1294,7 @@ static const struct msm_pingroup sdm670_groups[] = {
> SDC_QDSD_PINGROUP(sdc2_data, 0x9a000, 9, 0),
> };
>
> -const int sdm670_reserved_gpios[] = {
> +static const int sdm670_reserved_gpios[] = {
> 58, 59, 60, 61, 62, 63, 64, 69, 70, 71, 72, 73, 74, 104, -1
> };
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static
2022-10-20 7:56 [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static Yang Yingliang
2022-10-20 21:04 ` Richard Acayan
@ 2022-10-24 8:19 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-10-24 8:19 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-gpio, mailingradian
On Thu, Oct 20, 2022 at 9:58 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
> sdm670_reserved_gpios is only used in pinctrl-sdm670.c now, change it
> to static.
>
> Fixes: 61164d220f52 ("pinctrl: qcom: add sdm670 pinctrl")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Fixed up subject and applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-24 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 7:56 [PATCH -next] pinctrl: qcom: sdma670: change sdm670_reserved_gpios to static Yang Yingliang
2022-10-20 21:04 ` Richard Acayan
2022-10-24 8:19 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).