* [PATCH v1 1/1] gpiolib: cdev: Fix typo in kernel doc for struct line
@ 2022-10-20 15:39 Andy Shevchenko
2022-10-21 12:53 ` Kent Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-10-20 15:39 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski
When eflags has been renamed to the edflags, the kernel doc change were
missed. Update kernel doc accordingly.
Fixes: b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpiolib-cdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 0c84b011a64a..f9288e41e3a7 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -412,7 +412,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
* @desc: the GPIO descriptor for this line.
* @req: the corresponding line request
* @irq: the interrupt triggered in response to events on this GPIO
- * @eflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
+ * @edflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
* GPIO_V2_LINE_FLAG_EDGE_FALLING, indicating the edge detection applied
* @timestamp_ns: cache for the timestamp storing it between hardirq and
* IRQ thread, used to bring the timestamp close to the actual event
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] gpiolib: cdev: Fix typo in kernel doc for struct line
2022-10-20 15:39 [PATCH v1 1/1] gpiolib: cdev: Fix typo in kernel doc for struct line Andy Shevchenko
@ 2022-10-21 12:53 ` Kent Gibson
2022-10-25 16:48 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Kent Gibson @ 2022-10-21 12:53 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Linus Walleij, Bartosz Golaszewski
On Thu, Oct 20, 2022 at 06:39:14PM +0300, Andy Shevchenko wrote:
> When eflags has been renamed to the edflags, the kernel doc change were
> missed. Update kernel doc accordingly.
>
> Fixes: b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Kent Gibson <warthog618@gmail.com>
> ---
> drivers/gpio/gpiolib-cdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 0c84b011a64a..f9288e41e3a7 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -412,7 +412,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
> * @desc: the GPIO descriptor for this line.
> * @req: the corresponding line request
> * @irq: the interrupt triggered in response to events on this GPIO
> - * @eflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
> + * @edflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
> * GPIO_V2_LINE_FLAG_EDGE_FALLING, indicating the edge detection applied
> * @timestamp_ns: cache for the timestamp storing it between hardirq and
> * IRQ thread, used to bring the timestamp close to the actual event
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] gpiolib: cdev: Fix typo in kernel doc for struct line
2022-10-21 12:53 ` Kent Gibson
@ 2022-10-25 16:48 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-10-25 16:48 UTC (permalink / raw)
To: Kent Gibson; +Cc: linux-gpio, linux-kernel, Linus Walleij, Bartosz Golaszewski
On Fri, Oct 21, 2022 at 08:53:36PM +0800, Kent Gibson wrote:
> On Thu, Oct 20, 2022 at 06:39:14PM +0300, Andy Shevchenko wrote:
> > When eflags has been renamed to the edflags, the kernel doc change were
> > missed. Update kernel doc accordingly.
> >
> > Fixes: b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Kent Gibson <warthog618@gmail.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-25 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 15:39 [PATCH v1 1/1] gpiolib: cdev: Fix typo in kernel doc for struct line Andy Shevchenko
2022-10-21 12:53 ` Kent Gibson
2022-10-25 16:48 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).