From: Maulik Shah <mkshah@codeaurora.org>
To: Felipe Balbi <balbi@kernel.org>,
bjorn.andersson@linaro.org, maz@kernel.org,
linus.walleij@linaro.org, swboyd@chromium.org,
evgreen@chromium.org, mka@chromium.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, agross@kernel.org,
tglx@linutronix.de, jason@lakedaemon.net, dianders@chromium.org,
rnayak@codeaurora.org, ilina@codeaurora.org,
lsrao@codeaurora.org
Subject: Re: [PATCH v4 7/7] irqchip: qcom-pdc: Reset all pdc interrupts during init
Date: Thu, 13 Aug 2020 12:51:39 +0530 [thread overview]
Message-ID: <59e3398e-ec95-0820-c317-156841a46ae7@codeaurora.org> (raw)
In-Reply-To: <87imdqpusi.fsf@kernel.org>
Hi,
On 8/10/2020 5:39 PM, Felipe Balbi wrote:
> Maulik Shah <mkshah@codeaurora.org> writes:
>
>> Clear previous kernel's configuration during init by resetting
>> interrupts in enable bank to zero.
>>
>> Suggested-by: Stephen Boyd <swboyd@chromium.org>
>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>> ---
>> drivers/irqchip/qcom-pdc.c | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>> index dfcdfc5..80e0dfb 100644
>> --- a/drivers/irqchip/qcom-pdc.c
>> +++ b/drivers/irqchip/qcom-pdc.c
>> @@ -389,7 +389,8 @@ static const struct irq_domain_ops qcom_pdc_gpio_ops = {
>>
>> static int pdc_setup_pin_mapping(struct device_node *np)
>> {
>> - int ret, n;
>> + int ret, n, i;
>> + u32 irq_index, reg_index, val;
>>
>> n = of_property_count_elems_of_size(np, "qcom,pdc-ranges", sizeof(u32));
>> if (n <= 0 || n % 3)
>> @@ -418,6 +419,15 @@ static int pdc_setup_pin_mapping(struct device_node *np)
>> &pdc_region[n].cnt);
>> if (ret)
>> return ret;
>> +
>> + for (i = pdc_region[n].pin_base; i < pdc_region[n].pin_base +
>> + pdc_region[n].cnt; i++) {
> how about making the for loop slightly easier to read by moving pin_base
> inside the loop?
>
> for (i = 0; i < pdc_region[n].cnt; i++) {
> reg_index = (i + pdc_region[n].pin_base) >> 5;
> irq_index = (i + pdc_region[n].pin_base) & 0x1f;
>
> [...]
> }
Sure, i will move pin_base inside for loop in v5.
Thanks,
Maulik
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-08-13 7:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 11:20 [PATCH v4 0/7] irqchip: qcom: pdc: Introduce irq_set_wake call Maulik Shah
2020-08-10 11:20 ` [PATCH v4 1/7] pinctrl: qcom: Add msmgpio irqchip flags Maulik Shah
2020-08-11 19:32 ` Stephen Boyd
2020-08-13 5:47 ` Maulik Shah
2020-08-11 20:04 ` Doug Anderson
2020-08-10 11:20 ` [PATCH v4 2/7] pinctrl: qcom: Use return value from irq_set_wake call Maulik Shah
2020-08-11 19:34 ` Stephen Boyd
2020-08-11 20:06 ` Doug Anderson
2020-08-13 7:17 ` Maulik Shah
2020-08-13 7:21 ` Stephen Boyd
2020-08-27 22:46 ` Linus Walleij
2020-08-10 11:20 ` [PATCH v4 3/7] genirq: Introduce irq_suspend_one() and irq_resume_one() callbacks Maulik Shah
2020-08-11 20:09 ` Doug Anderson
2020-08-13 7:18 ` Maulik Shah
2020-08-13 9:29 ` Thomas Gleixner
2020-08-13 16:09 ` Doug Anderson
2020-08-13 22:09 ` Thomas Gleixner
2020-08-13 22:58 ` Doug Anderson
2020-08-14 2:07 ` Thomas Gleixner
2020-08-14 3:04 ` Doug Anderson
2020-08-14 12:43 ` Thomas Gleixner
2020-08-18 4:35 ` Maulik Shah
2020-08-18 14:40 ` Thomas Gleixner
2020-08-10 11:20 ` [PATCH v4 4/7] genirq: introduce irq_suspend_parent() and irq_resume_parent() Maulik Shah
2020-08-11 20:10 ` Doug Anderson
2020-08-13 7:19 ` Maulik Shah
2020-08-10 11:20 ` [PATCH v4 5/7] pinctrl: qcom: Call our parent for irq_suspend_one / irq_resume_one Maulik Shah
2020-08-10 11:20 ` [PATCH v4 6/7] irqchip: qcom-pdc: Unmask wake up irqs during suspend Maulik Shah
2020-08-10 11:21 ` [PATCH v4 7/7] irqchip: qcom-pdc: Reset all pdc interrupts during init Maulik Shah
2020-08-10 12:09 ` Felipe Balbi
2020-08-13 7:21 ` Maulik Shah [this message]
2020-08-11 21:31 ` Stephen Boyd
2020-08-13 7:30 ` Maulik Shah
2020-08-14 20:24 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59e3398e-ec95-0820-c317-156841a46ae7@codeaurora.org \
--to=mkshah@codeaurora.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).