* [PATCH] gpio: fix kernel-doc for of_gpio_need_valid_mask()
@ 2019-10-08 20:40 Randy Dunlap
2019-10-09 8:07 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-10-08 20:40 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, linux-gpio; +Cc: LKML
From: Randy Dunlap <rdunlap@infradead.org>
Fix kernel-doc for of_gpio_need_valid_mask().
Fixes this warning and uses correct Return: format.
../drivers/gpio/gpiolib-of.c:92: warning: Excess function parameter 'dev' description in 'of_gpio_need_valid_mask'
Fixes: f626d6dfb709 ("gpio: of: Break out OF-only code")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio@vger.kernel.org
---
drivers/gpio/gpiolib-of.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next-20191008.orig/drivers/gpio/gpiolib-of.c
+++ linux-next-20191008/drivers/gpio/gpiolib-of.c
@@ -84,8 +84,9 @@ static struct gpio_desc *of_xlate_and_ge
/**
* of_gpio_need_valid_mask() - figure out if the OF GPIO driver needs
* to set the .valid_mask
- * @dev: the device for the GPIO provider
- * @return: true if the valid mask needs to be set
+ * @gc: the target gpio_chip
+ *
+ * Return: true if the valid mask needs to be set
*/
bool of_gpio_need_valid_mask(const struct gpio_chip *gc)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: fix kernel-doc for of_gpio_need_valid_mask()
2019-10-08 20:40 [PATCH] gpio: fix kernel-doc for of_gpio_need_valid_mask() Randy Dunlap
@ 2019-10-09 8:07 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-10-09 8:07 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Bartosz Golaszewski, linux-gpio, LKML
On Tue, Oct 8, 2019 at 10:40 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc for of_gpio_need_valid_mask().
> Fixes this warning and uses correct Return: format.
>
> ../drivers/gpio/gpiolib-of.c:92: warning: Excess function parameter 'dev' description in 'of_gpio_need_valid_mask'
>
> Fixes: f626d6dfb709 ("gpio: of: Break out OF-only code")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-09 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 20:40 [PATCH] gpio: fix kernel-doc for of_gpio_need_valid_mask() Randy Dunlap
2019-10-09 8:07 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).