* [PATCH] pinctrl: meson: axg: fix gpio_ao bank stop pin
@ 2018-01-16 16:29 Jerome Brunet
2018-01-17 0:23 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Jerome Brunet @ 2018-01-16 16:29 UTC (permalink / raw)
To: Linus Walleij
Cc: Jerome Brunet, Carlo Caione, Kevin Hilman, linux-gpio,
linux-amlogic, linux-kernel
GPIO bank mistakenly stops at GPIOAO_9 while it should stop at GPIOAO_13.
This gives -EINVAL if one tries to set/get anything on GPIOAO_10 to
GPIOAO_13 (pull, direction, value)
Correcting the bank last pin fixes this problem
Fixes: e072b0f1b03a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
Hi Linus,
This changes fixes code which was added during this cycle, so it intended
for your "for-next" branch, not the "fixes" one.
Thanks
Jerome
drivers/pinctrl/meson/pinctrl-meson-axg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
index a1a7d42afd42..6431d77a4704 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
@@ -897,8 +897,8 @@ static struct meson_bank meson_axg_periphs_banks[] = {
};
static struct meson_bank meson_axg_aobus_banks[] = {
- /* name first last irq pullen pull dir out in */
- BANK("AO", GPIOAO_0, GPIOAO_9, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0),
+ /* name first last irq pullen pull dir out in */
+ BANK("AO", GPIOAO_0, GPIOAO_13, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0),
};
static struct meson_pmx_bank meson_axg_periphs_pmx_banks[] = {
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: meson: axg: fix gpio_ao bank stop pin
2018-01-16 16:29 [PATCH] pinctrl: meson: axg: fix gpio_ao bank stop pin Jerome Brunet
@ 2018-01-17 0:23 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2018-01-17 0:23 UTC (permalink / raw)
To: Jerome Brunet
Cc: Linus Walleij, Carlo Caione, linux-gpio, linux-amlogic, linux-kernel
Jerome Brunet <jbrunet@baylibre.com> writes:
> GPIO bank mistakenly stops at GPIOAO_9 while it should stop at GPIOAO_13.
> This gives -EINVAL if one tries to set/get anything on GPIOAO_10 to
> GPIOAO_13 (pull, direction, value)
>
> Correcting the bank last pin fixes this problem
>
> Fixes: e072b0f1b03a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
>
> Hi Linus,
>
> This changes fixes code which was added during this cycle, so it intended
> for your "for-next" branch, not the "fixes" one.
>
> Thanks
> Jerome
>
> drivers/pinctrl/meson/pinctrl-meson-axg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> index a1a7d42afd42..6431d77a4704 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> @@ -897,8 +897,8 @@ static struct meson_bank meson_axg_periphs_banks[] = {
> };
>
> static struct meson_bank meson_axg_aobus_banks[] = {
> - /* name first last irq pullen pull dir out in */
> - BANK("AO", GPIOAO_0, GPIOAO_9, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0),
> + /* name first last irq pullen pull dir out in */
> + BANK("AO", GPIOAO_0, GPIOAO_13, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0),
> };
>
> static struct meson_pmx_bank meson_axg_periphs_pmx_banks[] = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-17 0:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-16 16:29 [PATCH] pinctrl: meson: axg: fix gpio_ao bank stop pin Jerome Brunet
2018-01-17 0:23 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).