* [PATCH v2 1/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place
2020-08-17 4:44 [PATCH v2 0/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place Kuninori Morimoto
@ 2020-08-17 4:46 ` Kuninori Morimoto
2020-08-21 13:56 ` Geert Uytterhoeven
2020-08-17 4:46 ` [PATCH v2 2/3] pinctrl: sh-pfc: align driver description title Kuninori Morimoto
2020-08-17 4:46 ` [PATCH v2 3/3] pinctrl: sh-pfc: sort " Kuninori Morimoto
2 siblings, 1 reply; 13+ messages in thread
From: Kuninori Morimoto @ 2020-08-17 4:46 UTC (permalink / raw)
To: Linus Walleij, Geert Uytterhoeven; +Cc: linux-gpio, linux-renesas-soc
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Renesas related pinctrl CONFIGs are located many places,
and it is confusable.
This patch collects these into same place,
and group into "Renesas pinctrl drivers" menu.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/pinctrl/Kconfig | 32 ------------------------------
drivers/pinctrl/sh-pfc/Kconfig | 36 ++++++++++++++++++++++++++++++++++
2 files changed, 36 insertions(+), 32 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 8828613c4e0e..f63c5a04a3f7 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -213,38 +213,6 @@ config PINCTRL_ROCKCHIP
select GENERIC_IRQ_CHIP
select MFD_SYSCON
-config PINCTRL_RZA1
- bool "Renesas RZ/A1 gpio and pinctrl driver"
- depends on OF
- depends on ARCH_R7S72100 || COMPILE_TEST
- select GPIOLIB
- select GENERIC_PINCTRL_GROUPS
- select GENERIC_PINMUX_FUNCTIONS
- select GENERIC_PINCONF
- help
- This selects pinctrl driver for Renesas RZ/A1 platforms.
-
-config PINCTRL_RZA2
- bool "Renesas RZ/A2 gpio and pinctrl driver"
- depends on OF
- depends on ARCH_R7S9210 || COMPILE_TEST
- select GPIOLIB
- select GENERIC_PINCTRL_GROUPS
- select GENERIC_PINMUX_FUNCTIONS
- select GENERIC_PINCONF
- help
- This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
-
-config PINCTRL_RZN1
- bool "Renesas RZ/N1 pinctrl driver"
- depends on OF
- depends on ARCH_RZN1 || COMPILE_TEST
- select GENERIC_PINCTRL_GROUPS
- select GENERIC_PINMUX_FUNCTIONS
- select GENERIC_PINCONF
- help
- This selects pinctrl driver for Renesas RZ/N1 devices.
-
config PINCTRL_SINGLE
tristate "One-register-per-pin type device tree based pinctrl driver"
depends on OF
diff --git a/drivers/pinctrl/sh-pfc/Kconfig b/drivers/pinctrl/sh-pfc/Kconfig
index c461a2f1927a..a16393e6b9c2 100644
--- a/drivers/pinctrl/sh-pfc/Kconfig
+++ b/drivers/pinctrl/sh-pfc/Kconfig
@@ -3,6 +3,8 @@
# Renesas SH and SH Mobile PINCTRL drivers
#
+menu "Renesas pinctrl drivers"
+
config PINCTRL_SH_PFC
bool "Renesas SoC pin control support" if COMPILE_TEST && !(ARCH_RENESAS || SUPERH)
default y if ARCH_RENESAS || SUPERH
@@ -52,6 +54,38 @@ config PINCTRL_SH_PFC
help
This enables pin control drivers for Renesas SuperH and ARM platforms
+config PINCTRL_RZA1
+ bool "RZ/A1 gpio and pinctrl driver"
+ depends on OF
+ depends on ARCH_R7S72100 || COMPILE_TEST
+ select GPIOLIB
+ select GENERIC_PINCTRL_GROUPS
+ select GENERIC_PINMUX_FUNCTIONS
+ select GENERIC_PINCONF
+ help
+ This selects pinctrl driver for Renesas RZ/A1 platforms.
+
+config PINCTRL_RZA2
+ bool "RZ/A2 gpio and pinctrl driver"
+ depends on OF
+ depends on ARCH_R7S9210 || COMPILE_TEST
+ select GPIOLIB
+ select GENERIC_PINCTRL_GROUPS
+ select GENERIC_PINMUX_FUNCTIONS
+ select GENERIC_PINCONF
+ help
+ This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
+
+config PINCTRL_RZN1
+ bool "RZ/N1 pinctrl driver"
+ depends on OF
+ depends on ARCH_RZN1 || COMPILE_TEST
+ select GENERIC_PINCTRL_GROUPS
+ select GENERIC_PINMUX_FUNCTIONS
+ select GENERIC_PINCONF
+ help
+ This selects pinctrl driver for Renesas RZ/N1 devices.
+
config PINCTRL_SH_PFC_GPIO
select GPIOLIB
bool
@@ -199,3 +233,5 @@ config PINCTRL_PFC_SH7786
config PINCTRL_PFC_SHX3
bool "SH-X3 pin control support" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
+
+endmenu
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place
2020-08-17 4:46 ` [PATCH v2 1/3] " Kuninori Morimoto
@ 2020-08-21 13:56 ` Geert Uytterhoeven
2020-08-24 0:04 ` Kuninori Morimoto
0 siblings, 1 reply; 13+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 13:56 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linus Walleij, open list:GPIO SUBSYSTEM, Linux-Renesas
On Mon, Aug 17, 2020 at 6:46 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Renesas related pinctrl CONFIGs are located many places,
> and it is confusable.
> This patch collects these into same place,
> and group into "Renesas pinctrl drivers" menu.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
into drivers/pinctrl/sh-pfc/, too.
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -213,38 +213,6 @@ config PINCTRL_ROCKCHIP
> select GENERIC_IRQ_CHIP
> select MFD_SYSCON
>
> -config PINCTRL_RZA1
> - bool "Renesas RZ/A1 gpio and pinctrl driver"
> - depends on OF
> - depends on ARCH_R7S72100 || COMPILE_TEST
> - select GPIOLIB
> - select GENERIC_PINCTRL_GROUPS
> - select GENERIC_PINMUX_FUNCTIONS
> - select GENERIC_PINCONF
> - help
> - This selects pinctrl driver for Renesas RZ/A1 platforms.
> -
> -config PINCTRL_RZA2
> - bool "Renesas RZ/A2 gpio and pinctrl driver"
> - depends on OF
> - depends on ARCH_R7S9210 || COMPILE_TEST
> - select GPIOLIB
> - select GENERIC_PINCTRL_GROUPS
> - select GENERIC_PINMUX_FUNCTIONS
> - select GENERIC_PINCONF
> - help
> - This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
> -
> -config PINCTRL_RZN1
> - bool "Renesas RZ/N1 pinctrl driver"
> - depends on OF
> - depends on ARCH_RZN1 || COMPILE_TEST
> - select GENERIC_PINCTRL_GROUPS
> - select GENERIC_PINMUX_FUNCTIONS
> - select GENERIC_PINCONF
> - help
> - This selects pinctrl driver for Renesas RZ/N1 devices.
> -
> config PINCTRL_SINGLE
> tristate "One-register-per-pin type device tree based pinctrl driver"
> depends on OF
> diff --git a/drivers/pinctrl/sh-pfc/Kconfig b/drivers/pinctrl/sh-pfc/Kconfig
> index c461a2f1927a..a16393e6b9c2 100644
> --- a/drivers/pinctrl/sh-pfc/Kconfig
> +++ b/drivers/pinctrl/sh-pfc/Kconfig
> @@ -3,6 +3,8 @@
> # Renesas SH and SH Mobile PINCTRL drivers
> #
>
> +menu "Renesas pinctrl drivers"
> +
> config PINCTRL_SH_PFC
> bool "Renesas SoC pin control support" if COMPILE_TEST && !(ARCH_RENESAS || SUPERH)
> default y if ARCH_RENESAS || SUPERH
> @@ -52,6 +54,38 @@ config PINCTRL_SH_PFC
> help
> This enables pin control drivers for Renesas SuperH and ARM platforms
>
> +config PINCTRL_RZA1
> + bool "RZ/A1 gpio and pinctrl driver"
> + depends on OF
> + depends on ARCH_R7S72100 || COMPILE_TEST
> + select GPIOLIB
> + select GENERIC_PINCTRL_GROUPS
> + select GENERIC_PINMUX_FUNCTIONS
> + select GENERIC_PINCONF
> + help
> + This selects pinctrl driver for Renesas RZ/A1 platforms.
> +
> +config PINCTRL_RZA2
> + bool "RZ/A2 gpio and pinctrl driver"
> + depends on OF
> + depends on ARCH_R7S9210 || COMPILE_TEST
> + select GPIOLIB
> + select GENERIC_PINCTRL_GROUPS
> + select GENERIC_PINMUX_FUNCTIONS
> + select GENERIC_PINCONF
> + help
> + This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
> +
> +config PINCTRL_RZN1
> + bool "RZ/N1 pinctrl driver"
> + depends on OF
> + depends on ARCH_RZN1 || COMPILE_TEST
> + select GENERIC_PINCTRL_GROUPS
> + select GENERIC_PINMUX_FUNCTIONS
> + select GENERIC_PINCONF
> + help
> + This selects pinctrl driver for Renesas RZ/N1 devices.
> +
> config PINCTRL_SH_PFC_GPIO
> select GPIOLIB
> bool
> @@ -199,3 +233,5 @@ config PINCTRL_PFC_SH7786
> config PINCTRL_PFC_SHX3
> bool "SH-X3 pin control support" if COMPILE_TEST
> select PINCTRL_SH_FUNC_GPIO
> +
> +endmenu
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place
2020-08-21 13:56 ` Geert Uytterhoeven
@ 2020-08-24 0:04 ` Kuninori Morimoto
2020-08-28 9:47 ` Linus Walleij
0 siblings, 1 reply; 13+ messages in thread
From: Kuninori Morimoto @ 2020-08-24 0:04 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linus Walleij, open list:GPIO SUBSYSTEM, Linux-Renesas
Hi Geert
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Renesas related pinctrl CONFIGs are located many places,
> > and it is confusable.
> > This patch collects these into same place,
> > and group into "Renesas pinctrl drivers" menu.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> into drivers/pinctrl/sh-pfc/, too.
As I mentioned before, I'm waiting Linus's opinion.
But will move these in v3 without waiting him.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place
2020-08-24 0:04 ` Kuninori Morimoto
@ 2020-08-28 9:47 ` Linus Walleij
2020-08-30 23:14 ` Kuninori Morimoto
0 siblings, 1 reply; 13+ messages in thread
From: Linus Walleij @ 2020-08-28 9:47 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Geert Uytterhoeven, open list:GPIO SUBSYSTEM, Linux-Renesas
On Mon, Aug 24, 2020 at 2:04 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > Renesas related pinctrl CONFIGs are located many places,
> > > and it is confusable.
> > > This patch collects these into same place,
> > > and group into "Renesas pinctrl drivers" menu.
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> > into drivers/pinctrl/sh-pfc/, too.
>
> As I mentioned before, I'm waiting Linus's opinion.
> But will move these in v3 without waiting him.
Sorry for slowness. I agree with this move, let's collect all the Renesas
stuff in one place.
Renaming it drivers/pinctrl/renesas may be a good idea too, but I'd let
Geert decide and execute that, it mainly affects him and his maintenance
work, not me.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place
2020-08-28 9:47 ` Linus Walleij
@ 2020-08-30 23:14 ` Kuninori Morimoto
2020-08-31 13:56 ` Geert Uytterhoeven
0 siblings, 1 reply; 13+ messages in thread
From: Kuninori Morimoto @ 2020-08-30 23:14 UTC (permalink / raw)
To: Linus Walleij; +Cc: Geert Uytterhoeven, open list:GPIO SUBSYSTEM, Linux-Renesas
Hi Linus
Cc Geert
Thank you for your feedback
> > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > >
> > > > Renesas related pinctrl CONFIGs are located many places,
> > > > and it is confusable.
> > > > This patch collects these into same place,
> > > > and group into "Renesas pinctrl drivers" menu.
> > > >
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> > > into drivers/pinctrl/sh-pfc/, too.
> >
> > As I mentioned before, I'm waiting Linus's opinion.
> > But will move these in v3 without waiting him.
>
> Sorry for slowness. I agree with this move, let's collect all the Renesas
> stuff in one place.
Thanks !
> Renaming it drivers/pinctrl/renesas may be a good idea too, but I'd let
> Geert decide and execute that, it mainly affects him and his maintenance
> work, not me.
Geert, my patch moves files, but do nothing to folder names.
I agree to Linus's opinion, please execute it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 1/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place
2020-08-30 23:14 ` Kuninori Morimoto
@ 2020-08-31 13:56 ` Geert Uytterhoeven
0 siblings, 0 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2020-08-31 13:56 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linus Walleij, open list:GPIO SUBSYSTEM, Linux-Renesas
Hi Morimoto-san,
On Mon, Aug 31, 2020 at 1:14 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > >
> > > > > Renesas related pinctrl CONFIGs are located many places,
> > > > > and it is confusable.
> > > > > This patch collects these into same place,
> > > > > and group into "Renesas pinctrl drivers" menu.
> > > > >
> > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > Still wondering about moving drivers/pinctrl/pinctrl-rz{a1,a2,n1}.c
> > > > into drivers/pinctrl/sh-pfc/, too.
> > >
> > > As I mentioned before, I'm waiting Linus's opinion.
> > > But will move these in v3 without waiting him.
> >
> > Sorry for slowness. I agree with this move, let's collect all the Renesas
> > stuff in one place.
>
> Thanks !
>
> > Renaming it drivers/pinctrl/renesas may be a good idea too, but I'd let
> > Geert decide and execute that, it mainly affects him and his maintenance
> > work, not me.
>
> Geert, my patch moves files, but do nothing to folder names.
> I agree to Linus's opinion, please execute it.
Thanks, I will take care of the rename.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 2/3] pinctrl: sh-pfc: align driver description title
2020-08-17 4:44 [PATCH v2 0/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place Kuninori Morimoto
2020-08-17 4:46 ` [PATCH v2 1/3] " Kuninori Morimoto
@ 2020-08-17 4:46 ` Kuninori Morimoto
2020-08-21 13:59 ` Geert Uytterhoeven
2020-08-17 4:46 ` [PATCH v2 3/3] pinctrl: sh-pfc: sort " Kuninori Morimoto
2 siblings, 1 reply; 13+ messages in thread
From: Kuninori Morimoto @ 2020-08-17 4:46 UTC (permalink / raw)
To: Linus Walleij, Geert Uytterhoeven; +Cc: linux-gpio, linux-renesas-soc
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Now, Renesas Pin Control drivers are under menu,
but current description are not aligned.
This patch align these.
- Emma Mobile AV2 pin control support
- R-Mobile APE6 pin control support
- R-Mobile A1 pin control support
- RZ/N1 pin control support
- RZ/G1H pin control support
- RZ/G1M pin control support
+ pin control support for Emma Mobile AV2
+ pin control support for R-Mobile APE6
+ pin control support for R-Mobile A1
+ pin control support for RZ/N1
+ pin control support for RZ/G1H
+ pin control support for RZ/G1M
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/pinctrl/sh-pfc/Kconfig | 86 +++++++++++++++++-----------------
1 file changed, 43 insertions(+), 43 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/Kconfig b/drivers/pinctrl/sh-pfc/Kconfig
index a16393e6b9c2..ed53ae4627ec 100644
--- a/drivers/pinctrl/sh-pfc/Kconfig
+++ b/drivers/pinctrl/sh-pfc/Kconfig
@@ -55,7 +55,7 @@ config PINCTRL_SH_PFC
This enables pin control drivers for Renesas SuperH and ARM platforms
config PINCTRL_RZA1
- bool "RZ/A1 gpio and pinctrl driver"
+ bool "gpio and pinctrl driver for RZ/A1"
depends on OF
depends on ARCH_R7S72100 || COMPILE_TEST
select GPIOLIB
@@ -66,7 +66,7 @@ config PINCTRL_RZA1
This selects pinctrl driver for Renesas RZ/A1 platforms.
config PINCTRL_RZA2
- bool "RZ/A2 gpio and pinctrl driver"
+ bool "gpio and pinctrl driver for RZ/A2"
depends on OF
depends on ARCH_R7S9210 || COMPILE_TEST
select GPIOLIB
@@ -77,7 +77,7 @@ config PINCTRL_RZA2
This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
config PINCTRL_RZN1
- bool "RZ/N1 pinctrl driver"
+ bool "pin control support for RZ/N1"
depends on OF
depends on ARCH_RZN1 || COMPILE_TEST
select GENERIC_PINCTRL_GROUPS
@@ -99,139 +99,139 @@ config PINCTRL_SH_FUNC_GPIO
This enables legacy function GPIOs for SH platforms
config PINCTRL_PFC_EMEV2
- bool "Emma Mobile AV2 pin control support" if COMPILE_TEST
+ bool "pin control support for Emma Mobile AV2" if COMPILE_TEST
config PINCTRL_PFC_R8A73A4
- bool "R-Mobile APE6 pin control support" if COMPILE_TEST
+ bool "pin control support for R-Mobile APE6" if COMPILE_TEST
select PINCTRL_SH_PFC_GPIO
config PINCTRL_PFC_R8A7740
- bool "R-Mobile A1 pin control support" if COMPILE_TEST
+ bool "pin control support for R-Mobile A1" if COMPILE_TEST
select PINCTRL_SH_PFC_GPIO
config PINCTRL_PFC_R8A7742
- bool "RZ/G1H pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G1H" if COMPILE_TEST
config PINCTRL_PFC_R8A7743
- bool "RZ/G1M pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G1M" if COMPILE_TEST
config PINCTRL_PFC_R8A7744
- bool "RZ/G1N pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G1N" if COMPILE_TEST
config PINCTRL_PFC_R8A7745
- bool "RZ/G1E pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G1E" if COMPILE_TEST
config PINCTRL_PFC_R8A77470
- bool "RZ/G1C pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G1C" if COMPILE_TEST
config PINCTRL_PFC_R8A774A1
- bool "RZ/G2M pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G2M" if COMPILE_TEST
config PINCTRL_PFC_R8A774B1
- bool "RZ/G2N pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G2N" if COMPILE_TEST
config PINCTRL_PFC_R8A774C0
- bool "RZ/G2E pin control support" if COMPILE_TEST
+ bool "pin control support for RZ/G2E" if COMPILE_TEST
config PINCTRL_PFC_R8A7778
- bool "R-Car M1A pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car M1A" if COMPILE_TEST
config PINCTRL_PFC_R8A7779
- bool "R-Car H1 pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car H1" if COMPILE_TEST
config PINCTRL_PFC_R8A7790
- bool "R-Car H2 pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car H2" if COMPILE_TEST
config PINCTRL_PFC_R8A7791
- bool "R-Car M2-W pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car M2-W" if COMPILE_TEST
config PINCTRL_PFC_R8A7792
- bool "R-Car V2H pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car V2H" if COMPILE_TEST
config PINCTRL_PFC_R8A7793
- bool "R-Car M2-N pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car M2-N" if COMPILE_TEST
config PINCTRL_PFC_R8A7794
- bool "R-Car E2 pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car E2" if COMPILE_TEST
config PINCTRL_PFC_R8A77950
- bool "R-Car H3 ES1.x pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car H3 ES1.x" if COMPILE_TEST
config PINCTRL_PFC_R8A77951
- bool "R-Car H3 ES2.0+ pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car H3 ES2.0+" if COMPILE_TEST
config PINCTRL_PFC_R8A77960
- bool "R-Car M3-W pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car M3-W" if COMPILE_TEST
config PINCTRL_PFC_R8A77961
- bool "R-Car M3-W+ pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car M3-W+" if COMPILE_TEST
config PINCTRL_PFC_R8A77965
- bool "R-Car M3-N pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car M3-N" if COMPILE_TEST
config PINCTRL_PFC_R8A77970
- bool "R-Car V3M pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car V3M" if COMPILE_TEST
config PINCTRL_PFC_R8A77980
- bool "R-Car V3H pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car V3H" if COMPILE_TEST
config PINCTRL_PFC_R8A77990
- bool "R-Car E3 pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car E3" if COMPILE_TEST
config PINCTRL_PFC_R8A77995
- bool "R-Car D3 pin control support" if COMPILE_TEST
+ bool "pin control support for R-Car D3" if COMPILE_TEST
config PINCTRL_PFC_SH7203
- bool "SH7203 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7203" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7264
- bool "SH7264 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7264" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7269
- bool "SH7269 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7269" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH73A0
- bool "SH-Mobile AG5 pin control support" if COMPILE_TEST
+ bool "pin control support for SH-Mobile AG5" if COMPILE_TEST
select PINCTRL_SH_PFC_GPIO
select REGULATOR
config PINCTRL_PFC_SH7720
- bool "SH7720 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7720" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7722
- bool "SH7722 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7722" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7723
- bool "SH-Mobile R2 pin control support" if COMPILE_TEST
+ bool "pin control support for SH-Mobile R2" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7724
- bool "SH-Mobile R2R pin control support" if COMPILE_TEST
+ bool "pin control support for SH-Mobile R2R" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7734
- bool "SH7734 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7734" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7757
- bool "SH7757 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7757" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7785
- bool "SH7785 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7785" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SH7786
- bool "SH7786 pin control support" if COMPILE_TEST
+ bool "pin control support for SH7786" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
config PINCTRL_PFC_SHX3
- bool "SH-X3 pin control support" if COMPILE_TEST
+ bool "pin control support for SH-X3" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
endmenu
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] pinctrl: sh-pfc: align driver description title
2020-08-17 4:46 ` [PATCH v2 2/3] pinctrl: sh-pfc: align driver description title Kuninori Morimoto
@ 2020-08-21 13:59 ` Geert Uytterhoeven
2020-08-24 0:05 ` Kuninori Morimoto
2020-08-24 0:28 ` Kuninori Morimoto
0 siblings, 2 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 13:59 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Linus Walleij, Geert Uytterhoeven, open list:GPIO SUBSYSTEM,
Linux-Renesas
Hi Morimoto-san,
Thanks for your patch!
On Mon, Aug 17, 2020 at 6:46 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Now, Renesas Pin Control drivers are under menu,
> but current description are not aligned.
> This patch align these.
>
> - Emma Mobile AV2 pin control support
Oops, that must be an old typo in the PFC subsystem => EV2 ;-)
> - R-Mobile APE6 pin control support
> - R-Mobile A1 pin control support
> - RZ/N1 pin control support
> - RZ/G1H pin control support
> - RZ/G1M pin control support
>
> + pin control support for Emma Mobile AV2
> + pin control support for R-Mobile APE6
> + pin control support for R-Mobile A1
> + pin control support for RZ/N1
> + pin control support for RZ/G1H
> + pin control support for RZ/G1M
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Note that your patch does not apply to v5.9-rc1 or my sh-pfc branch,
due to the addition of support for RZ/G2H.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] pinctrl: sh-pfc: align driver description title
2020-08-21 13:59 ` Geert Uytterhoeven
@ 2020-08-24 0:05 ` Kuninori Morimoto
2020-08-24 0:28 ` Kuninori Morimoto
1 sibling, 0 replies; 13+ messages in thread
From: Kuninori Morimoto @ 2020-08-24 0:05 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Geert Uytterhoeven, open list:GPIO SUBSYSTEM,
Linux-Renesas
Hi Geert
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Now, Renesas Pin Control drivers are under menu,
> > but current description are not aligned.
> > This patch align these.
> >
> > - Emma Mobile AV2 pin control support
>
> Oops, that must be an old typo in the PFC subsystem => EV2 ;-)
Oops, OK will adjust in v3
> Note that your patch does not apply to v5.9-rc1 or my sh-pfc branch,
> due to the addition of support for RZ/G2H.
OK, will adjust in v3
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] pinctrl: sh-pfc: align driver description title
2020-08-21 13:59 ` Geert Uytterhoeven
2020-08-24 0:05 ` Kuninori Morimoto
@ 2020-08-24 0:28 ` Kuninori Morimoto
1 sibling, 0 replies; 13+ messages in thread
From: Kuninori Morimoto @ 2020-08-24 0:28 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Geert Uytterhoeven, open list:GPIO SUBSYSTEM,
Linux-Renesas
Hi Geert
> Note that your patch does not apply to v5.9-rc1 or my sh-pfc branch,
> due to the addition of support for RZ/G2H.
On "renesas-drivers-2020-08-18-v5.9-rc1" is enough ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 3/3] pinctrl: sh-pfc: sort driver description title
2020-08-17 4:44 [PATCH v2 0/3] pinctrl: sh-pfc: collect Renesas related CONFIGs in one place Kuninori Morimoto
2020-08-17 4:46 ` [PATCH v2 1/3] " Kuninori Morimoto
2020-08-17 4:46 ` [PATCH v2 2/3] pinctrl: sh-pfc: align driver description title Kuninori Morimoto
@ 2020-08-17 4:46 ` Kuninori Morimoto
2020-08-21 14:02 ` Geert Uytterhoeven
2 siblings, 1 reply; 13+ messages in thread
From: Kuninori Morimoto @ 2020-08-17 4:46 UTC (permalink / raw)
To: Linus Walleij, Geert Uytterhoeven; +Cc: linux-gpio, linux-renesas-soc
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Some Renesas drivers are not organized, or organized by Chip number.
Because of it, menu table is not readable.
This patch sort these.
This patch do
- Collect RZ/xx in one place
- Collect SH-Mobile xx in one place
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/pinctrl/sh-pfc/Kconfig | 46 +++++++++++++++++-----------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/Kconfig b/drivers/pinctrl/sh-pfc/Kconfig
index ed53ae4627ec..f5b3f8854c7b 100644
--- a/drivers/pinctrl/sh-pfc/Kconfig
+++ b/drivers/pinctrl/sh-pfc/Kconfig
@@ -76,16 +76,6 @@ config PINCTRL_RZA2
help
This selects GPIO and pinctrl driver for Renesas RZ/A2 platforms.
-config PINCTRL_RZN1
- bool "pin control support for RZ/N1"
- depends on OF
- depends on ARCH_RZN1 || COMPILE_TEST
- select GENERIC_PINCTRL_GROUPS
- select GENERIC_PINMUX_FUNCTIONS
- select GENERIC_PINCONF
- help
- This selects pinctrl driver for Renesas RZ/N1 devices.
-
config PINCTRL_SH_PFC_GPIO
select GPIOLIB
bool
@@ -109,6 +99,16 @@ config PINCTRL_PFC_R8A7740
bool "pin control support for R-Mobile A1" if COMPILE_TEST
select PINCTRL_SH_PFC_GPIO
+config PINCTRL_RZN1
+ bool "pin control support for RZ/N1"
+ depends on OF
+ depends on ARCH_RZN1 || COMPILE_TEST
+ select GENERIC_PINCTRL_GROUPS
+ select GENERIC_PINMUX_FUNCTIONS
+ select GENERIC_PINCONF
+ help
+ This selects pinctrl driver for Renesas RZ/N1 devices.
+
config PINCTRL_PFC_R8A7742
bool "pin control support for RZ/G1H" if COMPILE_TEST
@@ -193,11 +193,6 @@ config PINCTRL_PFC_SH7269
bool "pin control support for SH7269" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
-config PINCTRL_PFC_SH73A0
- bool "pin control support for SH-Mobile AG5" if COMPILE_TEST
- select PINCTRL_SH_PFC_GPIO
- select REGULATOR
-
config PINCTRL_PFC_SH7720
bool "pin control support for SH7720" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
@@ -206,14 +201,6 @@ config PINCTRL_PFC_SH7722
bool "pin control support for SH7722" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
-config PINCTRL_PFC_SH7723
- bool "pin control support for SH-Mobile R2" if COMPILE_TEST
- select PINCTRL_SH_FUNC_GPIO
-
-config PINCTRL_PFC_SH7724
- bool "pin control support for SH-Mobile R2R" if COMPILE_TEST
- select PINCTRL_SH_FUNC_GPIO
-
config PINCTRL_PFC_SH7734
bool "pin control support for SH7734" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
@@ -230,6 +217,19 @@ config PINCTRL_PFC_SH7786
bool "pin control support for SH7786" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
+config PINCTRL_PFC_SH73A0
+ bool "pin control support for SH-Mobile AG5" if COMPILE_TEST
+ select PINCTRL_SH_PFC_GPIO
+ select REGULATOR
+
+config PINCTRL_PFC_SH7723
+ bool "pin control support for SH-Mobile R2" if COMPILE_TEST
+ select PINCTRL_SH_FUNC_GPIO
+
+config PINCTRL_PFC_SH7724
+ bool "pin control support for SH-Mobile R2R" if COMPILE_TEST
+ select PINCTRL_SH_FUNC_GPIO
+
config PINCTRL_PFC_SHX3
bool "pin control support for SH-X3" if COMPILE_TEST
select PINCTRL_SH_FUNC_GPIO
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v2 3/3] pinctrl: sh-pfc: sort driver description title
2020-08-17 4:46 ` [PATCH v2 3/3] pinctrl: sh-pfc: sort " Kuninori Morimoto
@ 2020-08-21 14:02 ` Geert Uytterhoeven
0 siblings, 0 replies; 13+ messages in thread
From: Geert Uytterhoeven @ 2020-08-21 14:02 UTC (permalink / raw)
To: Kuninori Morimoto; +Cc: Linus Walleij, open list:GPIO SUBSYSTEM, Linux-Renesas
On Mon, Aug 17, 2020 at 6:46 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Some Renesas drivers are not organized, or organized by Chip number.
> Because of it, menu table is not readable.
> This patch sort these.
>
> This patch do
> - Collect RZ/xx in one place
> - Collect SH-Mobile xx in one place
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 13+ messages in thread