* [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins
@ 2021-01-20 5:03 Drew Fustini
2021-01-20 8:01 ` Emmanuel Vadot
2021-01-22 13:20 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Drew Fustini @ 2021-01-20 5:03 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, linux-gpio, devicetree, linux-kernel
Cc: Drew Fustini, Emmanuel Vadot, Tony Lindgren
Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
Reported-by: Emmanuel Vadot <manu@bidouilliste.com>
Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
index f903eb4471f8..bb9999119314 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
@@ -8,7 +8,7 @@ Required properties:
- reg : offset and length of the register set for the mux registers
- #pinctrl-cells : number of cells in addition to the index, set to 1
- for pinctrl-single,pins and 2 for pinctrl-single,bits
+ or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits
- pinctrl-single,register-width : pinmux register access width in bits
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins
2021-01-20 5:03 [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins Drew Fustini
@ 2021-01-20 8:01 ` Emmanuel Vadot
2021-01-21 7:06 ` Tony Lindgren
2021-01-22 13:20 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Emmanuel Vadot @ 2021-01-20 8:01 UTC (permalink / raw)
To: Drew Fustini
Cc: Linus Walleij, Rob Herring, linux-gpio, devicetree, linux-kernel,
Tony Lindgren
On Tue, 19 Jan 2021 21:03:44 -0800
Drew Fustini <drew@beagleboard.org> wrote:
> Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
>
> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> Reported-by: Emmanuel Vadot <manu@bidouilliste.com>
> Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> index f903eb4471f8..bb9999119314 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
> @@ -8,7 +8,7 @@ Required properties:
> - reg : offset and length of the register set for the mux registers
>
> - #pinctrl-cells : number of cells in addition to the index, set to 1
> - for pinctrl-single,pins and 2 for pinctrl-single,bits
> + or 2 for pinctrl-single,pins and set to 2 for pinctrl-single,bits
>
> - pinctrl-single,register-width : pinmux register access width in bits
>
> --
> 2.25.1
>
Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org>
Thanks, now the docs make more sense :)
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins
2021-01-20 8:01 ` Emmanuel Vadot
@ 2021-01-21 7:06 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2021-01-21 7:06 UTC (permalink / raw)
To: Emmanuel Vadot
Cc: Drew Fustini, Linus Walleij, Rob Herring, linux-gpio, devicetree,
linux-kernel
* Emmanuel Vadot <manu@bidouilliste.com> [210120 08:01]:
> On Tue, 19 Jan 2021 21:03:44 -0800
> Drew Fustini <drew@beagleboard.org> wrote:
>
> > Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
...
> Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org>
>
> Thanks, now the docs make more sense :)
Looks good to me too:
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins
2021-01-20 5:03 [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins Drew Fustini
2021-01-20 8:01 ` Emmanuel Vadot
@ 2021-01-22 13:20 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2021-01-22 13:20 UTC (permalink / raw)
To: Drew Fustini
Cc: Rob Herring, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Emmanuel Vadot, Tony Lindgren
On Wed, Jan 20, 2021 at 6:04 AM Drew Fustini <drew@beagleboard.org> wrote:
> Document that #pinctrl-cells can be 1 or 2 for pinctrl-single,pins
>
> Fixes: 27c90e5e48d0 ("ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2")
> Reported-by: Emmanuel Vadot <manu@bidouilliste.com>
> Link: https://lore.kernel.org/linux-gpio/20210115190201.9273b637a7f967e7e55bc740@bidouilliste.com/
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-22 13:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 5:03 [PATCH] pinctrl: clarify #pinctrl-cells for pinctrl-single,pins Drew Fustini
2021-01-20 8:01 ` Emmanuel Vadot
2021-01-21 7:06 ` Tony Lindgren
2021-01-22 13:20 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).