Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* next-20190904: build failure in cp210x usb serial, gpio related?
@ 2019-09-08  8:51 Pavel Machek
  2019-09-10 10:25 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Machek @ 2019-09-08  8:51 UTC (permalink / raw)
  To: johan, gregkh, linux-usb, linux-kernel, linus.walleij,
	bgolaszewski, linux-gpio, sfr

[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]

Hi!

I'm getting this compiling the -next:

  CC      drivers/net/wireless/intel/iwlwifi/mvm/mac80211.o
  In file included from drivers/usb/serial/cp210x.c:23:
  ./include/linux/gpio/driver.h:722:19: error: static declaration of
  ‘gpiochip_lock_as_irq’ follows non-static declaration
    722 | static inline int gpiochip_lock_as_irq(struct gpio_chip
  *chip,
        |                   ^~~~~~~~~~~~~~~~~~~~
	./include/linux/gpio/driver.h:706:5: note: previous
  declaration of ‘gpiochip_lock_as_irq’ was here
    706 | int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned
  int offset);
        |     ^~~~~~~~~~~~~~~~~~~~
	./include/linux/gpio/driver.h:729:20: error: static
  declaration of ‘gpiochip_unlock_as_irq’ follows non-static
  declaration
    729 | static inline void gpiochip_unlock_as_irq(struct gpio_chip
  *chip,
        |                    ^~~~~~~~~~~~~~~~~~~~~~
	./include/linux/gpio/driver.h:707:6: note: previous
  declaration of ‘gpiochip_unlock_as_irq’ was here
    707 | void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned
  int offset);
        |      ^~~~~~~~~~~~~~~~~~~~~~
	make[3]: *** [scripts/Makefile.build:265:
  drivers/usb/serial/cp210x.o] Error 1
  make[2]: *** [scripts/Makefile.build:509: drivers/usb/serial] Error
  2
  make[2]: *** Waiting for unfinished jobs....
    CC      drivers/gpu/drm/ttm/ttm_page_alloc.o
      AR      drivers/usb/storage/built-in.a


Sounds like some fixes are needed in gpio headers?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: next-20190904: build failure in cp210x usb serial, gpio related?
  2019-09-08  8:51 next-20190904: build failure in cp210x usb serial, gpio related? Pavel Machek
@ 2019-09-10 10:25 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-09-10 10:25 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Johan Hovold, Greg KH, linux-usb, linux-kernel,
	Bartosz Golaszewski, open list:GPIO SUBSYSTEM, Stephen Rothwell

On Sun, Sep 8, 2019 at 9:51 AM Pavel Machek <pavel@denx.de> wrote:

> I'm getting this compiling the -next:
(...)
>   ./include/linux/gpio/driver.h:722:19: error: static declaration of
>   ‘gpiochip_lock_as_irq’ follows non-static declaration
>     722 | static inline int gpiochip_lock_as_irq(struct gpio_chip
>   *chip,

Yes this was fixed pretty much the same day the next release came
out, and by now I got like 4 different patches solving the same problem,
because no new next releases are coming out right now...
bad timing with no next releases during the kernel summit, sorry!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-08  8:51 next-20190904: build failure in cp210x usb serial, gpio related? Pavel Machek
2019-09-10 10:25 ` Linus Walleij

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org linux-gpio@archiver.kernel.org
	public-inbox-index linux-gpio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox