* Regression caused by a603a2b8d86e "gpio: of: Add special quirk to parse regulator flags"
@ 2018-01-16 20:49 Heiner Kallweit
2018-01-16 22:49 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2018-01-16 20:49 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio
With the latest next kernel I get a NPE caused by mentioned commit.
The change doesn't consider that the flags parameter can be NULL,
e.g. of_get_named_gpio() sets it to NULL.
All that of_gpio_flags_quirks() does is adjusting the flags,
so the following simple change fixed the issue for me.
if (flags)
of_gpio_flags_quirks(np, flags);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Regression caused by a603a2b8d86e "gpio: of: Add special quirk to parse regulator flags"
2018-01-16 20:49 Regression caused by a603a2b8d86e "gpio: of: Add special quirk to parse regulator flags" Heiner Kallweit
@ 2018-01-16 22:49 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-01-16 22:49 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: linux-gpio
On Tue, Jan 16, 2018 at 9:49 PM, Heiner Kallweit <hkallweit1@gmail.com> wrote:
> With the latest next kernel I get a NPE caused by mentioned commit.
> The change doesn't consider that the flags parameter can be NULL,
> e.g. of_get_named_gpio() sets it to NULL.
> All that of_gpio_flags_quirks() does is adjusting the flags,
> so the following simple change fixed the issue for me.
>
> if (flags)
> of_gpio_flags_quirks(np, flags);
How sloppy of me.
I sent a patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-16 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-16 20:49 Regression caused by a603a2b8d86e "gpio: of: Add special quirk to parse regulator flags" Heiner Kallweit
2018-01-16 22:49 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).