From: Linus Walleij <linus.walleij@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Maulik Shah <mkshah@codeaurora.org>,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable
Date: Sat, 20 Jun 2020 23:03:05 +0200 [thread overview]
Message-ID: <CACRpkdaNSw3jfYFY21LcrnV+40=VBSiaCsZeHDmscb0pkRuybg@mail.gmail.com> (raw)
In-Reply-To: <1592224927-28576-1-git-send-email-rnayak@codeaurora.org>
On Mon, Jun 15, 2020 at 2:42 PM Rajendra Nayak <rnayak@codeaurora.org> wrote:
> It would have been nice to be able to do this only for the particular
> board with this design, however this change of removing gpio28 from the
> pinctrl SoC file means we end up with one less wakeup capable gpio for
> the entire SoC.
Yeah but what about only removing it for this board in the driver then?
> @@ -1122,7 +1122,7 @@ static const struct msm_pingroup sc7180_groups[] = {
> static const struct msm_gpio_wakeirq_map sc7180_pdc_map[] = {
> {0, 40}, {3, 50}, {4, 42}, {5, 70}, {6, 41}, {9, 35},
> {10, 80}, {11, 51}, {16, 20}, {21, 55}, {22, 90}, {23, 21},
> - {24, 61}, {26, 52}, {28, 36}, {30, 100}, {31, 33}, {32, 81},
> + {24, 61}, {26, 52}, {30, 100}, {31, 33}, {32, 81},
> {33, 62}, {34, 43}, {36, 91}, {37, 53}, {38, 63}, {39, 72},
> {41, 101}, {42, 7}, {43, 34}, {45, 73}, {47, 82}, {49, 17},
> {52, 109}, {53, 102}, {55, 92}, {56, 56}, {57, 57}, {58, 83},
Make a copy of this tuple-array and in sc7180_pinctrl_probe()
set sc7180_pinctrl.wakeirq_map and .nwakeirq_map to something
board specific like that:
if (of_machine_is_compatible("my,board")) {
sc7180_pinctrl..wakeirq_map = ... ;
}
Yours,
Linus Walleij
prev parent reply other threads:[~2020-06-20 21:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 12:42 [PATCH] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable Rajendra Nayak
2020-06-20 21:03 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaNSw3jfYFY21LcrnV+40=VBSiaCsZeHDmscb0pkRuybg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).