Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] gpio: mpc8xxx: Add platform device to gpiochip->parent
@ 2019-11-26  6:51 Johnson CH Chen (陳昭勳)
  2019-11-28 13:39 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Johnson CH Chen (陳昭勳) @ 2019-11-26  6:51 UTC (permalink / raw)
  To: Linus Walleij, linux-gpio, linux-kernel; +Cc: zero19850401

Dear Linus Walleij,

In old kernels, some APIs still try to use parent->of_node from struct gpio_chip,
and it could be resulted in kernel panic because parent is NULL. Adding platform
device to gpiochip->parent can fix this problem.

Signed-off-by: Johnson Chen <johnsonch.chen@moxa.com>
Link: https://patchwork.kernel.org/patch/11234609

---
 drivers/gpio/gpio-mpc8xxx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 16a47de29c94..161e3ff4106a 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -346,6 +346,7 @@ static int mpc8xxx_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	gc = &mpc8xxx_gc->gc;
+	gc->parent = &pdev->dev;
 
 	if (of_property_read_bool(np, "little-endian")) {
 		ret = bgpio_init(gc, &pdev->dev, 4,
-- 
2.11.0

Best regards,
Johnson

Moxa Inc.
Fl. 4, No. 135, Lane 235, Baoqiao Rd.
Xindian Dist., New Taipei City, Taiwan, R.O.C.
Tel : +886-2-8919-1230 ext.1075
JohnsonCH.Chen@moxa.com 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpio: mpc8xxx: Add platform device to gpiochip->parent
  2019-11-26  6:51 [PATCH] gpio: mpc8xxx: Add platform device to gpiochip->parent Johnson CH Chen (陳昭勳)
@ 2019-11-28 13:39 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-11-28 13:39 UTC (permalink / raw)
  To: Johnson CH Chen (陳昭勳)
  Cc: linux-gpio, linux-kernel, zero19850401

Hi Johnson,

On Tue, Nov 26, 2019 at 7:51 AM Johnson CH Chen (陳昭勳)
<JohnsonCH.Chen@moxa.com> wrote:

> In old kernels, some APIs still try to use parent->of_node from struct gpio_chip,
> and it could be resulted in kernel panic because parent is NULL. Adding platform
> device to gpiochip->parent can fix this problem.
>
> Signed-off-by: Johnson Chen <johnsonch.chen@moxa.com>
> Link: https://patchwork.kernel.org/patch/11234609

Patch applied for fixes!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26  6:51 [PATCH] gpio: mpc8xxx: Add platform device to gpiochip->parent Johnson CH Chen (陳昭勳)
2019-11-28 13:39 ` Linus Walleij

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git