linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits
Date: Wed, 29 Mar 2023 10:44:34 +0200	[thread overview]
Message-ID: <CACRpkdbc1p_BmGkQRNJYxjNAahJQQ_5+zUadm4fh4UxRmM_PyQ@mail.gmail.com> (raw)
In-Reply-To: <20230323205733.20763-1-asmaa@nvidia.com>

On Thu, Mar 23, 2023 at 9:57 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:

> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().
>
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>

Neat fixup,
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

      parent reply	other threads:[~2023-03-29  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 20:57 [PATCH v1] gpio: mmio: fix calculation of bgpio_bits Asmaa Mnebhi
2023-03-24 12:07 ` Andy Shevchenko
2023-03-24 12:09   ` Andy Shevchenko
2023-03-24 13:43     ` Asmaa Mnebhi
2023-07-10 17:26   ` Asmaa Mnebhi
2023-07-10 19:11     ` Bartosz Golaszewski
2023-03-29  8:44 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdbc1p_BmGkQRNJYxjNAahJQQ_5+zUadm4fh4UxRmM_PyQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=asmaa@nvidia.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).