From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits
Date: Fri, 24 Mar 2023 14:09:28 +0200 [thread overview]
Message-ID: <CAHp75VcJf-peTtFA9xP28OYUCzGCeG-4Uw2aHLMrM0Sx5RoKvg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vd4m79RhG-_KLRNzr0SPzphG07fOiTWwmGCfx8Lz=+6Vg@mail.gmail.com>
On Fri, Mar 24, 2023 at 2:07 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Thu, Mar 23, 2023 at 10:57 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
> >
> > If the "ngpios" property is specified, bgpio_bits is calculated
> > as the round up value of ngpio. At the moment, the only requirement
> > specified is that the round up value must be a multiple of 8 but
> > it should also be a power of 2 because we provide accessors based
> > on the bank size in bgpio_setup_accessors().
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Btw, I do not see the initial patch in Bart's tree. I suppose you may
simply send a v5 of the original one with this fix applied inplace.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-24 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 20:57 [PATCH v1] gpio: mmio: fix calculation of bgpio_bits Asmaa Mnebhi
2023-03-24 12:07 ` Andy Shevchenko
2023-03-24 12:09 ` Andy Shevchenko [this message]
2023-03-24 13:43 ` Asmaa Mnebhi
2023-07-10 17:26 ` Asmaa Mnebhi
2023-07-10 19:11 ` Bartosz Golaszewski
2023-03-29 8:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcJf-peTtFA9xP28OYUCzGCeG-4Uw2aHLMrM0Sx5RoKvg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=asmaa@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).