Linux-GPIO Archive on
 help / color / Atom feed
From: Linus Walleij <>
To: Ahmad Fatoum <>
Cc: Bartosz Golaszewski <>,
	Grygorii Strashko <>,
	Thierry Reding <>,
	Sascha Hauer <>,
	"open list:GPIO SUBSYSTEM" <>,
	"" <>
Subject: Re: [PATCH] gpio: don't use same lockdep class for all devm_gpiochip_add_data users
Date: Tue, 4 Aug 2020 01:23:11 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jul 31, 2020 at 2:39 PM Ahmad Fatoum <> wrote:

> Commit 959bc7b22bd2 ("gpio: Automatically add lockdep keys") documents
> in its commits message its intention to "create a unique class key for
> each driver".
> It does so by having gpiochip_add_data add in-place the definition of
> two static lockdep classes for LOCKDEP use. That way, every caller of
> the macro adds their gpiochip with unique lockdep classes.
> There are many indirect callers of gpiochip_add_data, however, via
> use of devm_gpiochip_add_data. devm_gpiochip_add_data has external
> linkage and all its users will share the same lockdep classes, which
> probably is not intended.
> Fix this by replicating the gpio_chip_add_data statics-in-macro for
> the devm_ version as well.
> Fixes: 959bc7b22bd2 ("gpio: Automatically add lockdep keys")
> Signed-off-by: Ahmad Fatoum <>
> ---
> This doesn't fix any particular problem I ran into, but the code
> looked buggy, at least to my lockdep-user-not-developer eyes.

Thanks patch applied, I think we had this fixed before
but managed to loose it in some API rewrite. Thanks for
fixing it up!

Linus Walleij

      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 12:38 Ahmad Fatoum
2020-07-31 15:19 ` Bartosz Golaszewski
2020-08-01 11:51 ` Andy Shevchenko
2020-08-03 23:23 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-GPIO Archive on

Archives are clonable:
	git clone --mirror linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ \
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone