* [PATCH] pinctrl: nomadik: nomadik: Add of_node_put() before return
@ 2019-08-04 15:51 Nishka Dasgupta
2019-08-06 12:51 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Nishka Dasgupta @ 2019-08-04 15:51 UTC (permalink / raw)
To: linus.walleij, linux-arm-kernel, linux-gpio; +Cc: Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index ddd1f466d302..2a8190b11d10 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1508,6 +1508,7 @@ static int nmk_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
&reserved_maps, num_maps);
if (ret < 0) {
pinctrl_utils_free_map(pctldev, *map, *num_maps);
+ of_node_put(np);
return ret;
}
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: nomadik: nomadik: Add of_node_put() before return
2019-08-04 15:51 [PATCH] pinctrl: nomadik: nomadik: Add of_node_put() before return Nishka Dasgupta
@ 2019-08-06 12:51 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2019-08-06 12:51 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: Linux ARM, open list:GPIO SUBSYSTEM
On Sun, Aug 4, 2019 at 5:51 PM Nishka Dasgupta <nishkadg.linux@gmail.com> wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-06 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-04 15:51 [PATCH] pinctrl: nomadik: nomadik: Add of_node_put() before return Nishka Dasgupta
2019-08-06 12:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).