linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* REGRESSION pinctrl armada-37xx
@ 2020-03-22  8:41 Marek Behun
  2020-03-25 23:21 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Behun @ 2020-03-22  8:41 UTC (permalink / raw)
  To: Peng Fan; +Cc: linux-gpio, linus.walleij

Hello,
I am encountering a regression caused by commit 
06e26b75f5e6 ("pinctrl: mvebu: armada-37xx: use use platform api").

The pinctrl driver won't load with error
[    2.374219] armada-37xx-pinctrl d0013800.pinctrl: invalid or no IRQ
[    2.381309] armada-37xx-pinctrl d0018800.pinctrl: invalid or no IRQ

I just spent several hours finding this, because it caused some weird
bugs for devices using gpio as irq source.

Either platform_irq_count should get fixed or we should revert this
commit.

Marek

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: REGRESSION pinctrl armada-37xx
  2020-03-22  8:41 REGRESSION pinctrl armada-37xx Marek Behun
@ 2020-03-25 23:21 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-03-25 23:21 UTC (permalink / raw)
  To: Marek Behun; +Cc: Peng Fan, linux-gpio

On Sun, Mar 22, 2020 at 9:42 AM Marek Behun <marek.behun@nic.cz> wrote:

> Hello,
> I am encountering a regression caused by commit
> 06e26b75f5e6 ("pinctrl: mvebu: armada-37xx: use use platform api").
>
> The pinctrl driver won't load with error
> [    2.374219] armada-37xx-pinctrl d0013800.pinctrl: invalid or no IRQ
> [    2.381309] armada-37xx-pinctrl d0018800.pinctrl: invalid or no IRQ
>
> I just spent several hours finding this, because it caused some weird
> bugs for devices using gpio as irq source.
>
> Either platform_irq_count should get fixed or we should revert this
> commit.

I reverted it now.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-25 23:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22  8:41 REGRESSION pinctrl armada-37xx Marek Behun
2020-03-25 23:21 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).