linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Palmer <daniel@0x0f.com>
To: Rob Herring <robh@kernel.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 1/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver
Date: Tue, 27 Oct 2020 00:15:45 +0900	[thread overview]
Message-ID: <CAFr9PXmuOCRoUiqNAdMi=xX142U46=Vnk-EHp9H02L8nut0esQ@mail.gmail.com> (raw)
In-Reply-To: <20201026134604.GA43947@bogus>

Hi Rob,

On Mon, 26 Oct 2020 at 22:46, Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Oct 19, 2020 at 11:10:04PM +0900, Daniel Palmer wrote:
> > Header adds defines for the gpio number of each pin
> > from the driver view. The gpio block seems to support 128 lines
> > but what line is mapped to a physical pin depends on the chip.
> > The driver itself uses the index of a pin's offset in an array
> > of the possible offsets for a chip as the gpio number.
> >
> > The defines remove the need to work out that index to consume
> > a pin in the device tree.
>
> I'd expect the DT to have 0-127 numbering... If you need to map that to
> another number, then an array property in DT could handle that.
>

Thank you for the comments on this header and the binding description.

Thinking about this again I'm thinking about having the GPIO numbers
be 0-127 like you say but supplying the valid offsets for that
specific chip and the pad/pin names to make visible to the user via an
array/arrays that contains the pin register offsets and the pin names.
Basically my per-chip table moves out of the driver and into the DT.
Does that sound acceptable? The main thing I want to avoid is
presenting the user with 128 gpios when the actually chip only has <10
of them wired up.

Thanks,

Daniel

  reply	other threads:[~2020-10-26 15:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 14:10 [PATCH v2 0/5] Add GPIO support for MStar/SigmaStar ARMv7 Daniel Palmer
2020-10-19 14:10 ` [PATCH v2 1/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver Daniel Palmer
2020-10-26 13:46   ` Rob Herring
2020-10-26 15:15     ` Daniel Palmer [this message]
2020-10-19 14:10 ` [PATCH v2 2/5] dt-bindings: gpio: Binding for MStar MSC313 GPIO controller Daniel Palmer
2020-10-26 13:48   ` Rob Herring
2020-10-19 14:10 ` [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver Daniel Palmer
2020-10-20 12:00   ` Andy Shevchenko
2020-10-20 13:26     ` Daniel Palmer
2020-11-05  9:30     ` Linus Walleij
2020-11-05  9:40   ` Linus Walleij
2020-11-05 12:08     ` Marc Zyngier
2020-11-05 15:23       ` Daniel Palmer
2020-11-05 15:43         ` Marc Zyngier
2020-11-10 14:02           ` Linus Walleij
2020-11-10 14:19             ` Marc Zyngier
2020-11-11 14:09               ` Linus Walleij
2020-11-11 14:19                 ` Marc Zyngier
2020-10-19 14:10 ` [PATCH v2 4/5] ARM: mstar: Add gpio controller to MStar base dtsi Daniel Palmer
2020-11-05  9:43   ` Linus Walleij
2020-10-19 14:10 ` [PATCH v2 5/5] ARM: mstar: Fill in GPIO controller properties for infinity Daniel Palmer
2020-11-05  9:44   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFr9PXmuOCRoUiqNAdMi=xX142U46=Vnk-EHp9H02L8nut0esQ@mail.gmail.com' \
    --to=daniel@0x0f.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).