From: Marc Zyngier <maz@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Palmer <daniel@0x0f.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver
Date: Tue, 10 Nov 2020 14:19:56 +0000 [thread overview]
Message-ID: <bc0ab2f10bb72fe5b455ca12958f6444@kernel.org> (raw)
In-Reply-To: <CACRpkdYr+yhyROQzaYfFrGwG74DuZiA=fMVOesgOKrDajhTodQ@mail.gmail.com>
On 2020-11-10 14:02, Linus Walleij wrote:
> On Thu, Nov 5, 2020 at 4:43 PM Marc Zyngier <maz@kernel.org> wrote:
>> On 2020-11-05 15:23, Daniel Palmer wrote:
>> > On Thu, 5 Nov 2020 at 21:08, Marc Zyngier <maz@kernel.org> wrote:
>
>> > > I see that msc313_gpio_irqchip doesn't have a
>> >> .irq_set_affinity callback. Is this system UP only?
>> >
>> > What is in mainline right now is UP only but there are chips with a
>> > second cortex A7 that I have working in my tree.
>> > So I will add that in for v3 if I can work out what I should actually
>> > do there. :)
>>
>> Probably nothing more than setting the callback to
>> irq_chip_set_affinity_parent,
>
> Hm, is this something all GPIO irqchips used on SMP systems
> should be doing? Or just hierarchical ones?
Probably only the hierarchical ones. I'd expect the non-hierarchical
GPIOs to be muxed behind a single interrupt, which makes it impossible
to move a single GPIO around, and moving the mux interrupt would break
userspace's expectations that interrupts move independently of each
others.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-11-10 14:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 14:10 [PATCH v2 0/5] Add GPIO support for MStar/SigmaStar ARMv7 Daniel Palmer
2020-10-19 14:10 ` [PATCH v2 1/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver Daniel Palmer
2020-10-26 13:46 ` Rob Herring
2020-10-26 15:15 ` Daniel Palmer
2020-10-19 14:10 ` [PATCH v2 2/5] dt-bindings: gpio: Binding for MStar MSC313 GPIO controller Daniel Palmer
2020-10-26 13:48 ` Rob Herring
2020-10-19 14:10 ` [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver Daniel Palmer
2020-10-20 12:00 ` Andy Shevchenko
2020-10-20 13:26 ` Daniel Palmer
2020-11-05 9:30 ` Linus Walleij
2020-11-05 9:40 ` Linus Walleij
2020-11-05 12:08 ` Marc Zyngier
2020-11-05 15:23 ` Daniel Palmer
2020-11-05 15:43 ` Marc Zyngier
2020-11-10 14:02 ` Linus Walleij
2020-11-10 14:19 ` Marc Zyngier [this message]
2020-11-11 14:09 ` Linus Walleij
2020-11-11 14:19 ` Marc Zyngier
2020-10-19 14:10 ` [PATCH v2 4/5] ARM: mstar: Add gpio controller to MStar base dtsi Daniel Palmer
2020-11-05 9:43 ` Linus Walleij
2020-10-19 14:10 ` [PATCH v2 5/5] ARM: mstar: Fill in GPIO controller properties for infinity Daniel Palmer
2020-11-05 9:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0ab2f10bb72fe5b455ca12958f6444@kernel.org \
--to=maz@kernel.org \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).