[PATCH] gpio: pca953x: Add support for the PCAL9535

[PATCH] gpio: pca953x: Add support for the PCAL9535

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

The PCAL9535 [1] is compatible to the PCA9535. Additionally, it comes
with interrupt support and input latching. Other features are not
supported by the GPIO subsystem.

[1] https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 drivers/gpio/gpio-pca953x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 1fca8dd7824f..34d635e51dda 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -1131,6 +1131,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 	{ .compatible = "nxp,pca9505", .data = OF_953X(40, PCA_INT), },
 	{ .compatible = "nxp,pca9534", .data = OF_953X( 8, PCA_INT), },
 	{ .compatible = "nxp,pca9535", .data = OF_953X(16, PCA_INT), },
+	{ .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pca9536", .data = OF_953X( 4, 0), },
 	{ .compatible = "nxp,pca9537", .data = OF_953X( 4, PCA_INT), },
 	{ .compatible = "nxp,pca9538", .data = OF_953X( 8, PCA_INT), },
--
2.26.2

Re: [PATCH] gpio: pca953x: Add support for the PCAL9535

[Bartosz Golaszewski]

sob., 13 cze 2020 o 16:44 Jan Kiszka <jan.kiszka@web.de> napisał(a):
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The PCAL9535 [1] is compatible to the PCA9535. Additionally, it comes
> with interrupt support and input latching. Other features are not
> supported by the GPIO subsystem.
>
> [1] https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/gpio/gpio-pca953x.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 1fca8dd7824f..34d635e51dda 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -1131,6 +1131,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
>         { .compatible = "nxp,pca9505", .data = OF_953X(40, PCA_INT), },
>         { .compatible = "nxp,pca9534", .data = OF_953X( 8, PCA_INT), },
>         { .compatible = "nxp,pca9535", .data = OF_953X(16, PCA_INT), },
> +       { .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
>         { .compatible = "nxp,pca9536", .data = OF_953X( 4, 0), },
>         { .compatible = "nxp,pca9537", .data = OF_953X( 4, PCA_INT), },
>         { .compatible = "nxp,pca9538", .data = OF_953X( 8, PCA_INT), },
> --
> 2.26.2
>

There should be a corresponding device-tree bindings change in the
same series but in a separate patch.

Bartosz

Re: [PATCH] gpio: pca953x: Add support for the PCAL9535

[Andy Shevchenko]

On Sat, Jun 13, 2020 at 5:45 PM Jan Kiszka <jan.kiszka@web.de> wrote:
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The PCAL9535 [1] is compatible to the PCA9535. Additionally, it comes
> with interrupt support and input latching. Other features are not
> supported by the GPIO subsystem.
>

> [1] https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Can we have this as a Datasheet: tag?


> @@ -1131,6 +1131,7 @@ static const struct of_device_id pca953x_dt_ids[] = {

> +       { .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },

Also, please update I²C ID table.

-- 
With Best Regards,
Andy Shevchenko