linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] gpio: Add support for the PCAL9535
@ 2020-06-15 13:22 Jan Kiszka
  2020-06-15 13:22 ` [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Jan Kiszka @ 2020-06-15 13:22 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski
  Cc: linux-gpio, linux-kernel, Andy Shevchenko

Changes in v3:
 - extend also I2C table
 - tag "Datasheet:" in commit log

Changes in v2:
 - add dt binding update

Jan

Jan Kiszka (2):
  dt-bindings: gpio: pca953x: add nxp,pcal9535
  gpio: pca953x: Add support for the PCAL9535

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 drivers/gpio/gpio-pca953x.c                             | 2 ++
 2 files changed, 3 insertions(+)

-- 
2.26.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535
  2020-06-15 13:22 [PATCH v3 0/2] gpio: Add support for the PCAL9535 Jan Kiszka
@ 2020-06-15 13:22 ` Jan Kiszka
  2020-06-16  8:50   ` Bartosz Golaszewski
  2020-06-15 13:22 ` [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
  2020-06-15 13:39 ` [PATCH v3 0/2] gpio: " Andy Shevchenko
  2 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2020-06-15 13:22 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski
  Cc: linux-gpio, linux-kernel, Andy Shevchenko

From: Jan Kiszka <jan.kiszka@siemens.com>

The NXP PCAL9535 is an extended variant of the PCA9535.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
index dab537c20def..3126c3817e2a 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
@@ -19,6 +19,7 @@ Required properties:
 	nxp,pca9698
 	nxp,pcal6416
 	nxp,pcal6524
+	nxp,pcal9535
 	nxp,pcal9555a
 	maxim,max7310
 	maxim,max7312
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535
  2020-06-15 13:22 [PATCH v3 0/2] gpio: Add support for the PCAL9535 Jan Kiszka
  2020-06-15 13:22 ` [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
@ 2020-06-15 13:22 ` Jan Kiszka
  2020-06-16  8:50   ` Bartosz Golaszewski
  2020-06-15 13:39 ` [PATCH v3 0/2] gpio: " Andy Shevchenko
  2 siblings, 1 reply; 6+ messages in thread
From: Jan Kiszka @ 2020-06-15 13:22 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski
  Cc: linux-gpio, linux-kernel, Andy Shevchenko

From: Jan Kiszka <jan.kiszka@siemens.com>

The PCAL9535 is compatible to the PCA9535. Additionally, it comes with
interrupt support and input latching. Other features are not supported
by the GPIO subsystem.

Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 drivers/gpio/gpio-pca953x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 1fca8dd7824f..cd5fb522563e 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -89,6 +89,7 @@ static const struct i2c_device_id pca953x_id[] = {
 
 	{ "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 	{ "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
+	{ "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 	{ "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 
 	{ "max7310", 8  | PCA953X_TYPE, },
@@ -1145,6 +1146,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 
 	{ .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
+	{ .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },
 
 	{ .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 0/2] gpio: Add support for the PCAL9535
  2020-06-15 13:22 [PATCH v3 0/2] gpio: Add support for the PCAL9535 Jan Kiszka
  2020-06-15 13:22 ` [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
  2020-06-15 13:22 ` [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
@ 2020-06-15 13:39 ` Andy Shevchenko
  2 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2020-06-15 13:39 UTC (permalink / raw)
  To: Jan Kiszka
  Cc: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
	Linux Kernel Mailing List

On Mon, Jun 15, 2020 at 4:22 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> Changes in v3:
>  - extend also I2C table
>  - tag "Datasheet:" in commit log

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks!

>
> Changes in v2:
>  - add dt binding update
>
> Jan
>
> Jan Kiszka (2):
>   dt-bindings: gpio: pca953x: add nxp,pcal9535
>   gpio: pca953x: Add support for the PCAL9535
>
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
>  drivers/gpio/gpio-pca953x.c                             | 2 ++
>  2 files changed, 3 insertions(+)
>
> --
> 2.26.2
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535
  2020-06-15 13:22 ` [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
@ 2020-06-16  8:50   ` Bartosz Golaszewski
  0 siblings, 0 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2020-06-16  8:50 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Linus Walleij, linux-gpio, LKML, Andy Shevchenko

pon., 15 cze 2020 o 15:22 Jan Kiszka <jan.kiszka@siemens.com> napisał(a):
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The NXP PCAL9535 is an extended variant of the PCA9535.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> index dab537c20def..3126c3817e2a 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
> @@ -19,6 +19,7 @@ Required properties:
>         nxp,pca9698
>         nxp,pcal6416
>         nxp,pcal6524
> +       nxp,pcal9535
>         nxp,pcal9555a
>         maxim,max7310
>         maxim,max7312
> --
> 2.26.2
>

Patch applied with Andy's review tag.

Bart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535
  2020-06-15 13:22 ` [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
@ 2020-06-16  8:50   ` Bartosz Golaszewski
  0 siblings, 0 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2020-06-16  8:50 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: Linus Walleij, linux-gpio, LKML, Andy Shevchenko

pon., 15 cze 2020 o 15:22 Jan Kiszka <jan.kiszka@siemens.com> napisał(a):
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The PCAL9535 is compatible to the PCA9535. Additionally, it comes with
> interrupt support and input latching. Other features are not supported
> by the GPIO subsystem.
>
> Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  drivers/gpio/gpio-pca953x.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 1fca8dd7824f..cd5fb522563e 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -89,6 +89,7 @@ static const struct i2c_device_id pca953x_id[] = {
>
>         { "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
>         { "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
> +       { "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
>         { "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
>
>         { "max7310", 8  | PCA953X_TYPE, },
> @@ -1145,6 +1146,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
>
>         { .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
>         { .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
> +       { .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
>         { .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },
>
>         { .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
> --
> 2.26.2
>

Patch applied with Andy's review tag.

Bart

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-06-16  8:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 13:22 [PATCH v3 0/2] gpio: Add support for the PCAL9535 Jan Kiszka
2020-06-15 13:22 ` [PATCH v3 1/2] dt-bindings: gpio: pca953x: add nxp,pcal9535 Jan Kiszka
2020-06-16  8:50   ` Bartosz Golaszewski
2020-06-15 13:22 ` [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535 Jan Kiszka
2020-06-16  8:50   ` Bartosz Golaszewski
2020-06-15 13:39 ` [PATCH v3 0/2] gpio: " Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).