* [PATCH] gpio: fix line flag validation in linehandle_create
@ 2019-09-09 3:22 Kent Gibson
2019-09-09 7:33 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Kent Gibson @ 2019-09-09 3:22 UTC (permalink / raw)
To: linux-gpio; +Cc: Kent Gibson
linehandle_create should not allow both GPIOHANDLE_REQUEST_INPUT
and GPIOHANDLE_REQUEST_OUTPUT to be set.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
drivers/gpio/gpiolib.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index cca749010cd0..7502230a4ec8 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -535,6 +535,14 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
if (lflags & ~GPIOHANDLE_REQUEST_VALID_FLAGS)
return -EINVAL;
+ /*
+ * Do not allow both INPUT & OUTPUT flags to be set as they are
+ * contradictory.
+ */
+ if ((lflags & GPIOHANDLE_REQUEST_INPUT) &&
+ (lflags & GPIOHANDLE_REQUEST_OUTPUT))
+ return -EINVAL;
+
/*
* Do not allow OPEN_SOURCE & OPEN_DRAIN flags in a single request. If
* the hardware actually supports enabling both at the same time the
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: fix line flag validation in linehandle_create
2019-09-09 3:22 [PATCH] gpio: fix line flag validation in linehandle_create Kent Gibson
@ 2019-09-09 7:33 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-09-09 7:33 UTC (permalink / raw)
To: Kent Gibson; +Cc: open list:GPIO SUBSYSTEM
pon., 9 wrz 2019 o 05:23 Kent Gibson <warthog618@gmail.com> napisał(a):
>
> linehandle_create should not allow both GPIOHANDLE_REQUEST_INPUT
> and GPIOHANDLE_REQUEST_OUTPUT to be set.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
> drivers/gpio/gpiolib.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index cca749010cd0..7502230a4ec8 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -535,6 +535,14 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
> if (lflags & ~GPIOHANDLE_REQUEST_VALID_FLAGS)
> return -EINVAL;
>
> + /*
> + * Do not allow both INPUT & OUTPUT flags to be set as they are
> + * contradictory.
> + */
> + if ((lflags & GPIOHANDLE_REQUEST_INPUT) &&
> + (lflags & GPIOHANDLE_REQUEST_OUTPUT))
> + return -EINVAL;
> +
> /*
> * Do not allow OPEN_SOURCE & OPEN_DRAIN flags in a single request. If
> * the hardware actually supports enabling both at the same time the
> --
> 2.23.0
>
This looks good, thanks. When sending v2 (after fixing the other
patch) please do the following:
- send it to Linus and myself (addresses are listed in MAINTAINERS)
- send all patches as a single series
Thanks,
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-09 7:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 3:22 [PATCH] gpio: fix line flag validation in linehandle_create Kent Gibson
2019-09-09 7:33 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).