* [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function
@ 2023-03-19 14:36 Tom Rix
2023-03-19 21:17 ` Linus Walleij
2023-03-22 16:27 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-19 14:36 UTC (permalink / raw)
To: robert.jarzmik, linus.walleij, brgl, nathan, ndesaulniers
Cc: linux-gpio, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/gpio/gpio-pxa.c:174:19: error: unused function
'gpio_is_pxa_type' [-Werror,-Wunused-function]
static inline int gpio_is_pxa_type(int type)
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpio/gpio-pxa.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 1198ab0305d0..a1630ed4b741 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -171,11 +171,6 @@ static inline struct pxa_gpio_bank *gpio_to_pxabank(struct gpio_chip *c,
return chip_to_pxachip(c)->banks + gpio / 32;
}
-static inline int gpio_is_pxa_type(int type)
-{
- return (type & MMP_GPIO) == 0;
-}
-
static inline int gpio_is_mmp_type(int type)
{
return (type & MMP_GPIO) != 0;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function
2023-03-19 14:36 [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function Tom Rix
@ 2023-03-19 21:17 ` Linus Walleij
2023-03-22 16:27 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-03-19 21:17 UTC (permalink / raw)
To: Tom Rix
Cc: robert.jarzmik, brgl, nathan, ndesaulniers, linux-gpio,
linux-kernel, llvm
On Sun, Mar 19, 2023 at 3:36 PM Tom Rix <trix@redhat.com> wrote:
> clang with W=1 reports
> drivers/gpio/gpio-pxa.c:174:19: error: unused function
> 'gpio_is_pxa_type' [-Werror,-Wunused-function]
> static inline int gpio_is_pxa_type(int type)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function
2023-03-19 14:36 [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function Tom Rix
2023-03-19 21:17 ` Linus Walleij
@ 2023-03-22 16:27 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-03-22 16:27 UTC (permalink / raw)
To: Tom Rix
Cc: robert.jarzmik, linus.walleij, nathan, ndesaulniers, linux-gpio,
linux-kernel, llvm
On Sun, Mar 19, 2023 at 3:36 PM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/gpio/gpio-pxa.c:174:19: error: unused function
> 'gpio_is_pxa_type' [-Werror,-Wunused-function]
> static inline int gpio_is_pxa_type(int type)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpio/gpio-pxa.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index 1198ab0305d0..a1630ed4b741 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -171,11 +171,6 @@ static inline struct pxa_gpio_bank *gpio_to_pxabank(struct gpio_chip *c,
> return chip_to_pxachip(c)->banks + gpio / 32;
> }
>
> -static inline int gpio_is_pxa_type(int type)
> -{
> - return (type & MMP_GPIO) == 0;
> -}
> -
> static inline int gpio_is_mmp_type(int type)
> {
> return (type & MMP_GPIO) != 0;
> --
> 2.27.0
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-22 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-19 14:36 [PATCH] gpio: pxa: remove unused gpio_is_pxa_type function Tom Rix
2023-03-19 21:17 ` Linus Walleij
2023-03-22 16:27 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).