From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: tps65218: drop unneeded MODULE_ALIAS
Date: Wed, 22 Sep 2021 12:13:07 +0200 [thread overview]
Message-ID: <CAMpxmJVv0N_NkbNV2NmajMEydfYw3R4MuW0XkK-THnGyOQrZvQ@mail.gmail.com> (raw)
In-Reply-To: <20210916164641.135008-2-krzysztof.kozlowski@canonical.com>
On Thu, Sep 16, 2021 at 6:46 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/gpio/gpio-tps65218.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c
> index 3517debe2b0b..912382be48e1 100644
> --- a/drivers/gpio/gpio-tps65218.c
> +++ b/drivers/gpio/gpio-tps65218.c
> @@ -230,4 +230,3 @@ module_platform_driver(tps65218_gpio_driver);
> MODULE_AUTHOR("Nicolas Saenz Julienne <nicolassaenzj@gmail.com>");
> MODULE_DESCRIPTION("GPO interface for TPS65218 PMICs");
> MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform:tps65218-gpio");
> --
> 2.30.2
>
Applied, thanks!
Bart
next prev parent reply other threads:[~2021-09-22 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 16:46 [PATCH 1/2] gpio: max77620: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-09-16 16:46 ` [PATCH 2/2] gpio: tps65218: " Krzysztof Kozlowski
2021-09-22 10:13 ` Bartosz Golaszewski [this message]
2021-09-22 10:12 ` [PATCH 1/2] gpio: max77620: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJVv0N_NkbNV2NmajMEydfYw3R4MuW0XkK-THnGyOQrZvQ@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).