* Re: [PATCH 12/17] gpio: gpiolib.c: fix a doc warning
2020-03-17 14:54 ` [PATCH 12/17] gpio: gpiolib.c: fix a doc warning Mauro Carvalho Chehab
@ 2020-03-18 9:15 ` Bartosz Golaszewski
2020-03-27 10:22 ` Linus Walleij
2020-03-27 19:25 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2020-03-18 9:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Doc Mailing List, LKML, Jonathan Corbet, Linus Walleij, linux-gpio
wt., 17 mar 2020 o 15:54 Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> napisał(a):
>
> Use a different markup for the ERR_PTR, as %FOO doesn't work
> if there are parenthesis. So, use, instead:
>
> ``ERR_PTR(-EINVAL)``
>
> This fixes the following warning:
>
> ./drivers/gpio/gpiolib.c:139: WARNING: Inline literal start-string without end-string.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index f31b1d46599e..74d8973025da 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -136,7 +136,7 @@ EXPORT_SYMBOL_GPL(gpio_to_desc);
> * @hwnum: hardware number of the GPIO for this chip
> *
> * Returns:
> - * A pointer to the GPIO descriptor or %ERR_PTR(-EINVAL) if no GPIO exists
> + * A pointer to the GPIO descriptor or ``ERR_PTR(-EINVAL)`` if no GPIO exists
> * in the given chip for the specified hardware number.
> */
> struct gpio_desc *gpiochip_get_desc(struct gpio_chip *chip,
> --
> 2.24.1
>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 12/17] gpio: gpiolib.c: fix a doc warning
2020-03-17 14:54 ` [PATCH 12/17] gpio: gpiolib.c: fix a doc warning Mauro Carvalho Chehab
2020-03-18 9:15 ` Bartosz Golaszewski
@ 2020-03-27 10:22 ` Linus Walleij
2020-03-27 13:47 ` Mauro Carvalho Chehab
2020-03-27 19:25 ` Linus Walleij
2 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2020-03-27 10:22 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Doc Mailing List, linux-kernel, Jonathan Corbet,
Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Tue, Mar 17, 2020 at 3:54 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
> Use a different markup for the ERR_PTR, as %FOO doesn't work
> if there are parenthesis. So, use, instead:
>
> ``ERR_PTR(-EINVAL)``
>
> This fixes the following warning:
>
> ./drivers/gpio/gpiolib.c:139: WARNING: Inline literal start-string without end-string.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Mauro are you merging this or do you want me to merge it?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 12/17] gpio: gpiolib.c: fix a doc warning
2020-03-27 10:22 ` Linus Walleij
@ 2020-03-27 13:47 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2020-03-27 13:47 UTC (permalink / raw)
To: Linus Walleij
Cc: Linux Doc Mailing List, linux-kernel, Jonathan Corbet,
Bartosz Golaszewski, open list:GPIO SUBSYSTEM
Em Fri, 27 Mar 2020 11:22:52 +0100
Linus Walleij <linus.walleij@linaro.org> escreveu:
> On Tue, Mar 17, 2020 at 3:54 PM Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
>
> > Use a different markup for the ERR_PTR, as %FOO doesn't work
> > if there are parenthesis. So, use, instead:
> >
> > ``ERR_PTR(-EINVAL)``
> >
> > This fixes the following warning:
> >
> > ./drivers/gpio/gpiolib.c:139: WARNING: Inline literal start-string without end-string.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Mauro are you merging this or do you want me to merge it?
Feel free to merge it.
My plan is to rebase my trees after the merge window, re-sending
anything that got missed for them to be either applied directly
or via the docs tree.
Thanks,
Mauro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 12/17] gpio: gpiolib.c: fix a doc warning
2020-03-17 14:54 ` [PATCH 12/17] gpio: gpiolib.c: fix a doc warning Mauro Carvalho Chehab
2020-03-18 9:15 ` Bartosz Golaszewski
2020-03-27 10:22 ` Linus Walleij
@ 2020-03-27 19:25 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2020-03-27 19:25 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Doc Mailing List, linux-kernel, Jonathan Corbet,
Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Tue, Mar 17, 2020 at 3:54 PM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
> Use a different markup for the ERR_PTR, as %FOO doesn't work
> if there are parenthesis. So, use, instead:
>
> ``ERR_PTR(-EINVAL)``
>
> This fixes the following warning:
>
> ./drivers/gpio/gpiolib.c:139: WARNING: Inline literal start-string without end-string.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread