From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Joel Becker" <jlbec@evilplan.org>,
"Shuah Khan" <shuah@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Kent Gibson" <warthog618@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Jack Winch" <sunt.un.morcov@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v5 2/8] configfs: use BIT() for internal flags
Date: Mon, 20 Sep 2021 16:49:55 +0200 [thread overview]
Message-ID: <CAMuHMdXUpMvhjjgNdLgfJvaWWG9_oHa_pmx4TTy0mC1p1zUEmw@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=McQoD=cUHLu6TMyW85fdtXOm4x38tHVnEGjkVfcfX0mfA@mail.gmail.com>
Hi Bartosz,
On Mon, Sep 20, 2021 at 4:47 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Mon, Sep 20, 2021 at 4:30 PM Christoph Hellwig <hch@lst.de> wrote:
> > On Mon, Sep 20, 2021 at 04:29:30PM +0200, Geert Uytterhoeven wrote:
> > > On Mon, Sep 20, 2021 at 4:09 PM Christoph Hellwig <hch@lst.de> wrote:
> > > > On Mon, Sep 20, 2021 at 04:05:03PM +0200, Bartosz Golaszewski wrote:
> > > > > For better readability and maintenance: use the BIT() macro for flag
> > > > > definitions.
> > > >
> > > > NAK. BIT() is the stupidest macro in the kernel and shall not be used
> > > > ever. And I'm pretty sure we had this discussion a few times.
> > >
> > > Care to explain why it is a stupid macro?
> >
> > Please look at the previous thread. I'm tired of this discussion.
>
> The only previous answer from Christoph is this:
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2399968.html
Yep, found that one, too.
Now, as these definitions do not correspond to hardware register bits,
perhaps use an enum?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-09-20 14:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 14:05 [PATCH v5 0/8] gpio: implement the configfs testing module Bartosz Golaszewski
2021-09-20 14:05 ` [PATCH v5 1/8] configfs: increase the item name length Bartosz Golaszewski
2021-09-20 14:05 ` [PATCH v5 2/8] configfs: use BIT() for internal flags Bartosz Golaszewski
2021-09-20 14:09 ` Christoph Hellwig
2021-09-20 14:13 ` Bartosz Golaszewski
2021-09-20 14:15 ` Christoph Hellwig
2021-09-20 14:29 ` Geert Uytterhoeven
2021-09-20 14:30 ` Christoph Hellwig
2021-09-20 14:45 ` Bartosz Golaszewski
2021-09-20 14:49 ` Geert Uytterhoeven [this message]
2021-09-20 15:00 ` Bartosz Golaszewski
2021-09-20 17:25 ` Matthew Wilcox
2021-09-20 14:05 ` [PATCH v5 3/8] configfs: implement committable items Bartosz Golaszewski
2021-09-20 14:05 ` [PATCH v5 4/8] samples: configfs: add a committable group Bartosz Golaszewski
2021-09-20 14:05 ` [PATCH v5 5/8] gpio: sim: new testing module Bartosz Golaszewski
2021-09-20 14:05 ` [PATCH v5 6/8] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-09-20 14:05 ` [PATCH v5 7/8] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-09-20 14:05 ` [PATCH v5 8/8] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXUpMvhjjgNdLgfJvaWWG9_oHa_pmx4TTy0mC1p1zUEmw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sunt.un.morcov@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).