From: Chester Lin <clin@suse.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"NXP S32 Linux Team" <s32@nxp.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Ghennadi Procopciuc" <Ghennadi.Procopciuc@oss.nxp.com>,
"Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
"Radu Pirea" <radu-nicolae.pirea@nxp.com>,
"Andreas Färber" <afaerber@suse.de>,
"Matthias Brugger" <mbrugger@suse.com>
Subject: Re: [PATCH v5 5/5] pinctrl: s32: separate const device data from struct s32_pinctrl_soc_info
Date: Wed, 29 Mar 2023 12:25:54 +0800 [thread overview]
Message-ID: <ZCO90vGIx+Z+J9gz@linux-8mug> (raw)
In-Reply-To: <CACRpkda097RwHCZu+_WAJRP=MGo7g4j++WJ57P=H7xKa9j439g@mail.gmail.com>
Hi Linus and Andy,
On Mon, Mar 27, 2023 at 11:39:18PM +0200, Linus Walleij wrote:
> On Mon, Mar 27, 2023 at 1:59 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Mar 27, 2023 at 9:28 AM Chester Lin <clin@suse.com> wrote:
> > >
> > > The .data field in struct of_device_id is used as a const member so it's
> > > inappropriate to attach struct s32_pinctrl_soc_info with of_device_id
> > > because some members in s32_pinctrl_soc_info need to be filled by
> > > pinctrl-s32cc at runtime.
> > >
> > > For this reason, struct s32_pinctrl_soc_info must be allocated in
> > > pinctrl-s32cc and then create a new struct s32_pinctrl_soc_data in order
> > > to represent const .data in of_device_id. To combine these two structures,
> > > a s32_pinctrl_soc_data pointer is introduced in s32_pinctrl_soc_info.
> > >
> > > Besides, use of_device_get_match_data() instead of of_match_device() since
> > > the driver only needs to retrieve the .data from of_device_id.
> >
> > ...
> >
> > > -static struct s32_pinctrl_soc_info s32_pinctrl_info = {
> > > +static struct s32_pinctrl_soc_data s32_pinctrl_data = {
> >
> > I'm wondering why it's not const.
> >
> > But don't resend too quickly, let's wait for Linus to comment on this
> > and other stuff. It might be that he can amend this when applying.
>
> I don't dare to add const here given the compiler warnings it
> can easily spawn.
>
> Chester can you investigate if these can be static const?
>
> You would only need to resend this patch 5/5 because I applied
> all the others to lower your patch stack.
>
> Thanks for fixing!
> Yours,
> Linus Walleij
Thanks for reviewing this patch and Andy's suggestion looks good to me. The
s32_pinctrl_data should be const as well since the 'data' pointer in
of_device_id is declared as const.
Anyway, I have resent a revised 5/5 under the same mail thread:
https://lore.kernel.org/all/20230329041630.8011-1-clin@suse.com/T/#u
It can be compiled by the following two gcc versions without a warning on
drivers/pinctrl/nxp
- aarch64-native:
- gcc version 7.5.0 (SUSE Linux) <aarch64-native>
- cross-compilation on x86-64
- gcc version 13.0.1 20230127 (experimental) [revision ca8fb0096713a8477614ef874f16ba5bf16c48bc] (SUSE Linux)
Thanks!
Regards,
Chester
next prev parent reply other threads:[~2023-03-29 4:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 6:27 [PATCH v5 0/5] pinctrl: s32: driver improvements and generic struct use Chester Lin
2023-03-27 6:27 ` [PATCH v5 1/5] pinctrl: s32: refine error/return/config checks and simplify driver codes Chester Lin
2023-03-27 21:34 ` Linus Walleij
2023-03-27 6:27 ` [PATCH v5 2/5] pinctrl: s32cc: refactor pin config parsing Chester Lin
2023-03-27 21:35 ` Linus Walleij
2023-03-27 6:27 ` [PATCH v5 3/5] pinctrl: s32cc: embed generic struct pingroup Chester Lin
2023-03-27 21:36 ` Linus Walleij
2023-03-27 6:27 ` [PATCH v5 4/5] pinctrl: s32cc: Use generic struct data to describe pin function Chester Lin
2023-03-27 6:27 ` [PATCH v5 5/5] pinctrl: s32: separate const device data from struct s32_pinctrl_soc_info Chester Lin
2023-03-27 11:58 ` Andy Shevchenko
2023-03-27 21:39 ` Linus Walleij
2023-03-29 4:25 ` Chester Lin [this message]
2023-03-29 4:16 ` [RESEND PATCH " Chester Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCO90vGIx+Z+J9gz@linux-8mug \
--to=clin@suse.com \
--cc=Ghennadi.Procopciuc@oss.nxp.com \
--cc=afaerber@suse.de \
--cc=andrei.stefanescu@nxp.com \
--cc=andy.shevchenko@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=radu-nicolae.pirea@nxp.com \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).