* [PATCH] dt-bindings: gpio: Convert TI TPIC2810 GPIO Controller bindings to YAML
@ 2021-10-04 11:27 Aparna M
2021-10-04 12:12 ` Aswath Govindraju
0 siblings, 1 reply; 2+ messages in thread
From: Aparna M @ 2021-10-04 11:27 UTC (permalink / raw)
To: a-govindraju
Cc: vigneshr, grygorii.strashko, linus.walleij, robh+dt, devicetree,
linux-gpio, bgolaszewski, Aparna M
* Convert gpio-tpic2810 bindings to yaml format
* Remove outdated gpio-tpic2810 bindings in .txt format
Signed-off-by: Aparna M <a-m1@ti.com>
---
.../bindings/gpio/gpio-tpic2810.txt | 16 -------
.../bindings/gpio/gpio-tpic2810.yaml | 48 +++++++++++++++++++
2 files changed, 48 insertions(+), 16 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
create mode 100644 Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
diff --git a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
deleted file mode 100644
index 1afc2de7a537..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-TPIC2810 GPIO controller bindings
-
-Required properties:
- - compatible : Should be "ti,tpic2810".
- - reg : The I2C address of the device
- - gpio-controller : Marks the device node as a GPIO controller.
- - #gpio-cells : Should be two. For consumer use see gpio.txt.
-
-Example:
-
- gpio@60 {
- compatible = "ti,tpic2810";
- reg = <0x60>;
- gpio-controller;
- #gpio-cells = <2>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
new file mode 100644
index 000000000000..6d4e22143551
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/gpio-tpic2810.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TPIC2810 GPIO controller bindings
+
+maintainers:
+ - Aswath Govindraju <a-govindraju@ti.com>
+
+properties:
+ compatible:
+ enum:
+ - ti,tpic2810
+
+ reg:
+ maxItems: 1
+ description: The I2C address of the device
+
+ gpio-controller: true
+
+ "#gpio-cells":
+ const: 2
+
+required:
+ - compatible
+ - reg
+ - gpio-controller
+ - "#gpio-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio@60 {
+ compatible = "ti,tpic2810";
+ reg = <0x60>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+ };
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: gpio: Convert TI TPIC2810 GPIO Controller bindings to YAML
2021-10-04 11:27 [PATCH] dt-bindings: gpio: Convert TI TPIC2810 GPIO Controller bindings to YAML Aparna M
@ 2021-10-04 12:12 ` Aswath Govindraju
0 siblings, 0 replies; 2+ messages in thread
From: Aswath Govindraju @ 2021-10-04 12:12 UTC (permalink / raw)
To: Aparna M
Cc: vigneshr, grygorii.strashko, linus.walleij, robh+dt, devicetree,
linux-gpio, bgolaszewski
Hi Aparna,
On 04/10/21 4:57 pm, Aparna M wrote:
> * Convert gpio-tpic2810 bindings to yaml format
> * Remove outdated gpio-tpic2810 bindings in .txt format
>
Usually, I have not seen the commit messages being listed as points, but
rather written as paragraph.
Also, I see the following warnings on running dt_binding_check,
./Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml:10:4:
[warning] wrong indentation: expected 2 but found 3 (indentation)
./Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml:27:5:
[warning] wrong indentation: expected 2 but found 4 (indentation)
Thanks,
Aswath
> Signed-off-by: Aparna M <a-m1@ti.com>
> ---
> .../bindings/gpio/gpio-tpic2810.txt | 16 -------
> .../bindings/gpio/gpio-tpic2810.yaml | 48 +++++++++++++++++++
> 2 files changed, 48 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
> deleted file mode 100644
> index 1afc2de7a537..000000000000
> --- a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -TPIC2810 GPIO controller bindings
> -
> -Required properties:
> - - compatible : Should be "ti,tpic2810".
> - - reg : The I2C address of the device
> - - gpio-controller : Marks the device node as a GPIO controller.
> - - #gpio-cells : Should be two. For consumer use see gpio.txt.
> -
> -Example:
> -
> - gpio@60 {
> - compatible = "ti,tpic2810";
> - reg = <0x60>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - };
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
> new file mode 100644
> index 000000000000..6d4e22143551
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-tpic2810.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/gpio-tpic2810.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TPIC2810 GPIO controller bindings
> +
> +maintainers:
> + - Aswath Govindraju <a-govindraju@ti.com>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,tpic2810
> +
> + reg:
> + maxItems: 1
> + description: The I2C address of the device
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - "#gpio-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio@60 {
> + compatible = "ti,tpic2810";
> + reg = <0x60>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> + };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-04 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 11:27 [PATCH] dt-bindings: gpio: Convert TI TPIC2810 GPIO Controller bindings to YAML Aparna M
2021-10-04 12:12 ` Aswath Govindraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).