From: Randy Dunlap <rdunlap@infradead.org>
To: Rahul Tanwar <rahul.tanwar@linux.intel.com>, linus.walleij@linaro.org
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error
Date: Wed, 4 Dec 2019 19:42:08 -0800 [thread overview]
Message-ID: <b92f1c7c-efdb-340d-dbfa-2a083732d8fb@infradead.org> (raw)
In-Reply-To: <ba937f271d1a2173828a2325990d62cb36d61595.1575514110.git.rahul.tanwar@linux.intel.com>
On 12/4/19 7:01 PM, Rahul Tanwar wrote:
> Fix below linker error
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
> `pinconf_generic_dt_node_to_map_all':
> pinctrl-equilibrium.c:(.text+0xb): undefined reference
> to `pinconf_generic_dt_node_to_map'
>
> Caused by below commit
>
> 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
>
> by adding 'depends on OF' in Kconfig driver entry.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 3bfbf2ff6e2b..ba0cad4bd072 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -422,6 +422,7 @@ config PINCTRL_TB10X
>
> config PINCTRL_EQUILIBRIUM
> tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
> + depends on OF
> select PINMUX
> select PINCONF
> select GPIOLIB
>
--
~Randy
next prev parent reply other threads:[~2019-12-05 3:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 3:01 [PATCH 0/1] pinctrl: pinctrl-v5.5-2: Fix linker error Rahul Tanwar
2019-12-05 3:01 ` [PATCH 1/1] pinctrl: Modify Kconfig to fix " Rahul Tanwar
2019-12-05 3:42 ` Randy Dunlap [this message]
2019-12-13 10:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92f1c7c-efdb-340d-dbfa-2a083732d8fb@infradead.org \
--to=rdunlap@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rahul.tanwar@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).