* [PATCH 0/1] pinctrl: pinctrl-v5.5-2: Fix linker error
@ 2019-12-05 3:01 Rahul Tanwar
2019-12-05 3:01 ` [PATCH 1/1] pinctrl: Modify Kconfig to fix " Rahul Tanwar
0 siblings, 1 reply; 4+ messages in thread
From: Rahul Tanwar @ 2019-12-05 3:01 UTC (permalink / raw)
To: linus.walleij
Cc: rdunlap, sfr, linux-next, linux-kernel, linux-gpio, Rahul Tanwar
Fix linker error seen with 5.5 linux-next tree caused by below commit
1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC").
Patch is based on 'pinctrl-v5.5-2' tag of linux-pinctrl.git tree.
Rahul Tanwar (1):
pinctrl: Modify Kconfig to fix linker error
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error
2019-12-05 3:01 [PATCH 0/1] pinctrl: pinctrl-v5.5-2: Fix linker error Rahul Tanwar
@ 2019-12-05 3:01 ` Rahul Tanwar
2019-12-05 3:42 ` Randy Dunlap
2019-12-13 10:05 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Rahul Tanwar @ 2019-12-05 3:01 UTC (permalink / raw)
To: linus.walleij
Cc: rdunlap, sfr, linux-next, linux-kernel, linux-gpio, Rahul Tanwar
Fix below linker error
ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
`pinconf_generic_dt_node_to_map_all':
pinctrl-equilibrium.c:(.text+0xb): undefined reference
to `pinconf_generic_dt_node_to_map'
Caused by below commit
1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
by adding 'depends on OF' in Kconfig driver entry.
Reported-by: Randy Dunlap <rdunlap@infradead.org>>
Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 3bfbf2ff6e2b..ba0cad4bd072 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -422,6 +422,7 @@ config PINCTRL_TB10X
config PINCTRL_EQUILIBRIUM
tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
+ depends on OF
select PINMUX
select PINCONF
select GPIOLIB
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error
2019-12-05 3:01 ` [PATCH 1/1] pinctrl: Modify Kconfig to fix " Rahul Tanwar
@ 2019-12-05 3:42 ` Randy Dunlap
2019-12-13 10:05 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2019-12-05 3:42 UTC (permalink / raw)
To: Rahul Tanwar, linus.walleij; +Cc: sfr, linux-next, linux-kernel, linux-gpio
On 12/4/19 7:01 PM, Rahul Tanwar wrote:
> Fix below linker error
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
> `pinconf_generic_dt_node_to_map_all':
> pinctrl-equilibrium.c:(.text+0xb): undefined reference
> to `pinconf_generic_dt_node_to_map'
>
> Caused by below commit
>
> 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
>
> by adding 'depends on OF' in Kconfig driver entry.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 3bfbf2ff6e2b..ba0cad4bd072 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -422,6 +422,7 @@ config PINCTRL_TB10X
>
> config PINCTRL_EQUILIBRIUM
> tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
> + depends on OF
> select PINMUX
> select PINCONF
> select GPIOLIB
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error
2019-12-05 3:01 ` [PATCH 1/1] pinctrl: Modify Kconfig to fix " Rahul Tanwar
2019-12-05 3:42 ` Randy Dunlap
@ 2019-12-13 10:05 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-12-13 10:05 UTC (permalink / raw)
To: Rahul Tanwar
Cc: Randy Dunlap, Stephen Rothwell, Linux-Next Mailing List,
linux-kernel, open list:GPIO SUBSYSTEM
On Thu, Dec 5, 2019 at 4:01 AM Rahul Tanwar
<rahul.tanwar@linux.intel.com> wrote:
> Fix below linker error
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
> `pinconf_generic_dt_node_to_map_all':
> pinctrl-equilibrium.c:(.text+0xb): undefined reference
> to `pinconf_generic_dt_node_to_map'
>
> Caused by below commit
>
> 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
>
> by adding 'depends on OF' in Kconfig driver entry.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Patch applied for fixes, thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-13 10:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 3:01 [PATCH 0/1] pinctrl: pinctrl-v5.5-2: Fix linker error Rahul Tanwar
2019-12-05 3:01 ` [PATCH 1/1] pinctrl: Modify Kconfig to fix " Rahul Tanwar
2019-12-05 3:42 ` Randy Dunlap
2019-12-13 10:05 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).