From: Matthias Brugger <matthias.bgg@gmail.com>
To: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Alexandre Mergnat" <amergnat@baylibre.com>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Chaotian Jing" <chaotian.jing@mediatek.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Wenbin Mei" <wenbin.mei@mediatek.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-gpio@vger.kernel.org,
Alexandre Bailon <abailon@baylibre.com>,
Fabien Parent <fparent@baylibre.com>,
Amjad Ouled-Ameur <aouledameur@baylibre.com>
Subject: Re: [PATCH v3 08/17] arm64: dts: mediatek: add mmc support for mt8365 SoC
Date: Thu, 30 Mar 2023 19:28:53 +0200 [thread overview]
Message-ID: <c575ac46-28bf-254f-a3c1-e30885ba7933@gmail.com> (raw)
In-Reply-To: <c785d80f-e443-cae4-1e17-b79eb2dc385c@collabora.com>
On 29/03/2023 15:21, AngeloGioacchino Del Regno wrote:
> Il 29/03/23 10:54, Alexandre Mergnat ha scritto:
>> There are three ports of MSDC (MMC and SD Controller), which are:
>> - MSDC0: EMMC5.1
>> - MSDC1: SD3.0/SDIO3.0
>> - MSDC2: SDIO3.0+
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8365.dtsi | 39 ++++++++++++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
>> index 687011353f69..a67eeca28da5 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
>> @@ -399,6 +399,45 @@ usb_host: usb@11200000 {
>> };
>> };
>> + mmc0: mmc@11230000 {
>> + compatible = "mediatek,mt8365-mmc", "mediatek,mt8183-mmc";
>> + reg = <0 0x11230000 0 0x1000>,
>> + <0 0x11cd0000 0 0x1000>;
>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_LOW>;
>> + clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>,
>> + <&infracfg CLK_IFR_MSDC0_HCLK>,
>> + <&infracfg CLK_IFR_MSDC0_SRC>;
>> + clock-names = "source", "hclk", "source_cg";
>> + status = "disabled";
>> + };
>> +
>> + mmc1: mmc@11240000 {
>> + compatible = "mediatek,mt8365-mmc", "mediatek,mt8183-mmc";
>> + reg = <0 0x11240000 0 0x1000>,
>> + <0 0x11c90000 0 0x1000>;
>> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_LOW>;
>> + clocks = <&topckgen CLK_TOP_MSDC30_1_SEL>,
>> + <&infracfg CLK_IFR_MSDC1_HCLK>,
>> + <&infracfg CLK_IFR_MSDC1_SRC>;
>> + clock-names = "source", "hclk", "source_cg";
>> + status = "disabled";
>> + };
>> +
>> + mmc2: mmc@11250000 {
>> + compatible = "mediatek,mt8365-mmc", "mediatek,mt8183-mmc";
>> + reg = <0 0x11250000 0 0x1000>,
>> + <0 0x11c60000 0 0x1000>;
>> + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_LOW>;
>> + clocks = <&topckgen CLK_TOP_MSDC50_2_SEL>,
>> + <&infracfg CLK_IFR_MSDC2_HCLK>,
>> + <&infracfg CLK_IFR_MSDC2_SRC>,
>> + <&infracfg CLK_IFR_MSDC2_BK>,
>> + <&infracfg CLK_IFR_AP_MSDC0>;
>> + clock-names = "source", "hclk", "source_cg",
>> + "bus_clk", "sys_cg";
>
> clock-names for this do fit in one 90 columns line.
>
> After compressing it,
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
I applied the patch and dropped you Reviewed-by tag. I think it depends on the
taste of everybody how you prefer to structure this. I've also seen that on
boards you care (mt8183 in that case) there a clocks that don't adhere to the
criteria you mention here ;-)
Anyway many thanks for reviewing this and all the great work in general.
Honestly I feel I didn't made justice by dropping your tag, but as you stated so
explicitly... :)
Regards,
Matthias
next prev parent reply other threads:[~2023-03-30 17:29 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 8:54 [PATCH v3 00/17] Improve the MT8365 SoC and EVK board support Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 01/17] dt-bindings: watchdog: mediatek,mtk-wdt: add mt8365 Alexandre Mergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-30 17:16 ` Matthias Brugger
2023-04-16 15:52 ` Guenter Roeck
2023-03-29 8:54 ` [PATCH v3 02/17] dt-bindings: pinctrl: mediatek,mt8365-pinctrl: add drive strength property Alexandre Mergnat
2023-03-30 17:17 ` Matthias Brugger
2023-03-31 8:24 ` Krzysztof Kozlowski
2023-03-29 8:54 ` [PATCH v3 03/17] arm64: dts: mediatek: Increase the size BL31 reserved memory amergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-30 17:20 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 04/17] arm64: dts: mediatek: add watchdog support for mt8365 SoC Alexandre Mergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 05/17] arm64: dts: mediatek: add mt6357 device-tree amergnat
2023-03-29 13:17 ` AngeloGioacchino Del Regno
2023-03-30 17:22 ` Matthias Brugger
2023-03-31 9:41 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 06/17] arm64: dts: mediatek: add pwrap support to mt8365 SoC Alexandre Mergnat
2023-03-29 13:19 ` AngeloGioacchino Del Regno
2023-03-30 17:22 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 07/17] arm64: dts: mediatek: add mt6357 PMIC support for mt8365-evk Alexandre Mergnat
2023-03-29 13:20 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 08/17] arm64: dts: mediatek: add mmc support for mt8365 SoC Alexandre Mergnat
2023-03-29 13:21 ` AngeloGioacchino Del Regno
2023-03-30 17:28 ` Matthias Brugger [this message]
2023-03-29 8:54 ` [PATCH v3 09/17] arm64: dts: mediatek: add mmc support for mt8365-evk Alexandre Mergnat
2023-03-29 13:24 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 10/17] arm64: dts: mediatek: set vmc regulator as always on amergnat
2023-03-29 13:25 ` AngeloGioacchino Del Regno
2023-03-31 11:08 ` Alexandre Mergnat
2023-03-31 11:23 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 11/17] arm64: dts: mediatek: add usb controller support for mt8365-evk Alexandre Mergnat
2023-03-29 13:26 ` AngeloGioacchino Del Regno
2023-03-30 17:30 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 12/17] arm64: dts: mediatek: add ethernet support for mt8365 SoC Alexandre Mergnat
2023-03-29 13:27 ` AngeloGioacchino Del Regno
2023-03-30 17:31 ` Matthias Brugger
2023-03-29 8:54 ` [PATCH v3 13/17] arm64: dts: mediatek: add ethernet support for mt8365-evk Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 14/17] arm64: dts: mediatek: add OPP support for mt8365 SoC Alexandre Mergnat
2023-03-29 13:28 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 15/17] arm64: dts: mediatek: add cpufreq support for mt8365-evk Alexandre Mergnat
2023-03-29 13:28 ` AngeloGioacchino Del Regno
2023-03-29 8:54 ` [PATCH v3 16/17] arm64: dts: mediatek: fix systimer properties amergnat
2023-03-29 13:29 ` AngeloGioacchino Del Regno
2023-03-30 17:34 ` Matthias Brugger
2023-03-31 12:05 ` Alexandre Mergnat
2023-03-29 8:54 ` [PATCH v3 17/17] arm64: dts: mediatek: Add CPU Idle support amergnat
2023-03-29 13:31 ` AngeloGioacchino Del Regno
2023-03-30 0:09 ` [PATCH v3 00/17] Improve the MT8365 SoC and EVK board support Kevin Hilman
2023-03-30 9:54 ` Alexandre Mergnat
2023-03-30 20:56 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c575ac46-28bf-254f-a3c1-e30885ba7933@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=abailon@baylibre.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aouledameur@baylibre.com \
--cc=bero@baylibre.com \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
--cc=wim@linux-watchdog.org \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).