Re: [PATCH v3 07/17] arm64: dts: mediatek: add mt6357 PMIC support for mt8365-evk

From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: "Alexandre Mergnat" <amergnat@baylibre.com>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Chaotian Jing" <chaotian.jing@mediatek.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Wenbin Mei" <wenbin.mei@mediatek.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
	"Bernhard Rosenkränzer" <bero@baylibre.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org,
	linux-gpio@vger.kernel.org,
	Alexandre Bailon <abailon@baylibre.com>,
	Fabien Parent <fparent@baylibre.com>,
	Amjad Ouled-Ameur <aouledameur@baylibre.com>
Subject: Re: [PATCH v3 07/17] arm64: dts: mediatek: add mt6357 PMIC support for mt8365-evk
Date: Wed, 29 Mar 2023 15:20:10 +0200	[thread overview]
Message-ID: <f963453f-ef7e-1bec-66ae-4bb0354914c8@collabora.com> (raw)
In-Reply-To: <20230203-evk-board-support-v3-7-0003e80e0095@baylibre.com>

Il 29/03/23 10:54, Alexandre Mergnat ha scritto:
> This power management system chip integration helps to manage regulators
> and keys.
> 
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
>   arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
> index fc7f6d8ae173..2f88562c638a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
> @@ -12,6 +12,7 @@
>   #include <dt-bindings/input/input.h>
>   #include <dt-bindings/pinctrl/mt8365-pinfunc.h>
>   #include "mt8365.dtsi"
> +#include "mt6357.dtsi"
>   
>   / {
>   	model = "MediaTek MT8365 Open Platform EVK";
> @@ -96,6 +97,13 @@ &i2c0 {
>   	#size-cells = <0>;
>   };
>   
> +&mt6357_pmic {
> +	interrupt-parent = <&pio>;
> +	interrupts = <145 IRQ_TYPE_LEVEL_HIGH>;

Please... use:
	interrupts-extended = <&pio 145 IRQ_TYPE_LEVEL_HIGH>;

Cheers,
Angelo