linux-hardening.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic
@ 2021-09-05  6:24 Len Baker
  2021-09-07 16:55 ` James Smart
  2021-09-22  4:45 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Len Baker @ 2021-09-05  6:24 UTC (permalink / raw)
  To: James Smart, Ram Vegesna, James E.J. Bottomley, Martin K. Petersen
  Cc: Len Baker, Kees Cook, Hannes Reinecke, linux-scsi, target-devel,
	linux-hardening, linux-kernel

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
count * size in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
---
 drivers/scsi/elx/libefc/efc_fabric.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/elx/libefc/efc_fabric.c b/drivers/scsi/elx/libefc/efc_fabric.c
index d397220d9e54..f9412437ad47 100644
--- a/drivers/scsi/elx/libefc/efc_fabric.c
+++ b/drivers/scsi/elx/libefc/efc_fabric.c
@@ -686,7 +686,7 @@ efc_process_gidpt_payload(struct efc_node *node,
 	}

 	/* Allocate a buffer for all nodes */
-	active_nodes = kzalloc(port_count * sizeof(*active_nodes), GFP_ATOMIC);
+	active_nodes = kcalloc(port_count, sizeof(*active_nodes), GFP_ATOMIC);
 	if (!active_nodes) {
 		node_printf(node, "efc_malloc failed\n");
 		return -EIO;
--
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic
  2021-09-05  6:24 [PATCH] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic Len Baker
@ 2021-09-07 16:55 ` James Smart
  2021-09-22  4:45 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2021-09-07 16:55 UTC (permalink / raw)
  To: Len Baker, James Smart, Ram Vegesna, James E.J. Bottomley,
	Martin K. Petersen
  Cc: Kees Cook, Hannes Reinecke, linux-scsi, target-devel,
	linux-hardening, linux-kernel

On 9/4/2021 11:24 PM, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> 
> So, use the purpose specific kcalloc() function instead of the argument
> count * size in the kzalloc() function.
> 
> [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
> 
> Signed-off-by: Len Baker <len.baker@gmx.com>

Looks good.  Thanks

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic
  2021-09-05  6:24 [PATCH] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic Len Baker
  2021-09-07 16:55 ` James Smart
@ 2021-09-22  4:45 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-09-22  4:45 UTC (permalink / raw)
  To: Len Baker, James Smart, Ram Vegesna, James E.J. Bottomley
  Cc: Martin K . Petersen, linux-scsi, linux-kernel, Kees Cook,
	target-devel, linux-hardening, Hannes Reinecke

On Sun, 5 Sep 2021 08:24:48 +0200, Len Baker wrote:

> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
> 
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic
      https://git.kernel.org/mkp/scsi/c/0a5e20fc8ca7

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-22  4:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05  6:24 [PATCH] scsi: elx: libefc: Prefer kcalloc over open coded arithmetic Len Baker
2021-09-07 16:55 ` James Smart
2021-09-22  4:45 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).