From: rfoss@kernel.org
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Azeem Shaikh <azeemshaikh38@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: "Robert Foss" <rfoss@kernel.org>,
linux-kernel@vger.kernel.org, "Jonas Karlman" <jonas@kwiboo.se>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Guillaume BRUN" <the.cheaterman@gmail.com>,
linux-hardening@vger.kernel.org,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"David Airlie" <airlied@gmail.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Maxime Ripard" <maxime@cerno.tech>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
Date: Tue, 23 May 2023 19:21:49 +0200 [thread overview]
Message-ID: <168486250045.3617730.17499429425987433532.b4-ty@kernel.org> (raw)
In-Reply-To: <20230522155210.2336690-1-azeemshaikh38@gmail.com>
From: Robert Foss <rfoss@kernel.org>
On Mon, 22 May 2023 15:52:10 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]
Applied, thanks!
[1/1] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=37cee4876a45
Rob
prev parent reply other threads:[~2023-05-23 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 15:52 [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-22 20:15 ` Kees Cook
2023-05-23 17:21 ` rfoss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168486250045.3617730.17499429425987433532.b4-ty@kernel.org \
--to=rfoss@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=azeemshaikh38@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=l.stach@pengutronix.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=neil.armstrong@linaro.org \
--cc=the.cheaterman@gmail.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).