* [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
@ 2023-05-22 15:52 Azeem Shaikh
2023-05-22 20:15 ` Kees Cook
2023-05-23 17:21 ` rfoss
0 siblings, 2 replies; 3+ messages in thread
From: Azeem Shaikh @ 2023-05-22 15:52 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss
Cc: linux-hardening, Azeem Shaikh, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, linux-kernel, David Airlie, Daniel Vetter,
Ville Syrjälä,
Maxime Ripard, Lucas Stach, Guillaume BRUN, dri-devel
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 603bb3c51027..9d6dcaf317a1 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -533,7 +533,7 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi)
adap->owner = THIS_MODULE;
adap->dev.parent = hdmi->dev;
adap->algo = &dw_hdmi_algorithm;
- strlcpy(adap->name, "DesignWare HDMI", sizeof(adap->name));
+ strscpy(adap->name, "DesignWare HDMI", sizeof(adap->name));
i2c_set_adapdata(adap, hdmi);
ret = i2c_add_adapter(adap);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
2023-05-22 15:52 [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy Azeem Shaikh
@ 2023-05-22 20:15 ` Kees Cook
2023-05-23 17:21 ` rfoss
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2023-05-22 20:15 UTC (permalink / raw)
To: Azeem Shaikh
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, linux-hardening,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, linux-kernel,
David Airlie, Daniel Vetter, Ville Syrjälä,
Maxime Ripard, Lucas Stach, Guillaume BRUN, dri-devel
On Mon, May 22, 2023 at 03:52:10PM +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
2023-05-22 15:52 [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-22 20:15 ` Kees Cook
@ 2023-05-23 17:21 ` rfoss
1 sibling, 0 replies; 3+ messages in thread
From: rfoss @ 2023-05-23 17:21 UTC (permalink / raw)
To: Andrzej Hajda, Azeem Shaikh, Neil Armstrong
Cc: Robert Foss, linux-kernel, Jonas Karlman, Ville Syrjälä,
Daniel Vetter, Guillaume BRUN, linux-hardening, Jernej Skrabec,
Lucas Stach, David Airlie, Laurent Pinchart, Maxime Ripard,
dri-devel
From: Robert Foss <rfoss@kernel.org>
On Mon, 22 May 2023 15:52:10 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
>
> [...]
Applied, thanks!
[1/1] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=37cee4876a45
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-23 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-22 15:52 [PATCH] drm/bridge: dw-hdmi: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-22 20:15 ` Kees Cook
2023-05-23 17:21 ` rfoss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).