* [PATCH][next] mlxfw: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
@ 2023-05-15 19:22 Gustavo A. R. Silva
2023-05-16 7:23 ` Ido Schimmel
2023-05-16 18:18 ` Kees Cook
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2023-05-15 19:22 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: mlxsw, netdev, linux-kernel, Gustavo A. R. Silva, linux-hardening
Zero-length arrays are deprecated and we are moving towards adopting
C99 flexible-array members, instead. So, replace zero-length arrays
declarations alone in structs with the new DECLARE_FLEX_ARRAY()
helper macro.
This helper allows for flexible-array members alone in structs.
Link: https://github.com/KSPP/linux/issues/193
Link: https://github.com/KSPP/linux/issues/285
Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2_format.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2_format.h b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2_format.h
index b001e5258091..47f6cc0401c3 100644
--- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2_format.h
+++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2_format.h
@@ -44,7 +44,7 @@ MLXFW_MFA2_TLV(multi, struct mlxfw_mfa2_tlv_multi,
MLXFW_MFA2_TLV_MULTI_PART);
struct mlxfw_mfa2_tlv_psid {
- u8 psid[0];
+ DECLARE_FLEX_ARRAY(u8, psid);
} __packed;
MLXFW_MFA2_TLV_VARSIZE(psid, struct mlxfw_mfa2_tlv_psid,
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] mlxfw: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
2023-05-15 19:22 [PATCH][next] mlxfw: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Gustavo A. R. Silva
@ 2023-05-16 7:23 ` Ido Schimmel
2023-05-16 18:18 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2023-05-16 7:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
mlxsw, netdev, linux-kernel, linux-hardening
On Mon, May 15, 2023 at 01:22:48PM -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated and we are moving towards adopting
> C99 flexible-array members, instead. So, replace zero-length arrays
> declarations alone in structs with the new DECLARE_FLEX_ARRAY()
> helper macro.
>
> This helper allows for flexible-array members alone in structs.
>
> Link: https://github.com/KSPP/linux/issues/193
> Link: https://github.com/KSPP/linux/issues/285
> Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] mlxfw: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
2023-05-15 19:22 [PATCH][next] mlxfw: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Gustavo A. R. Silva
2023-05-16 7:23 ` Ido Schimmel
@ 2023-05-16 18:18 ` Kees Cook
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2023-05-16 18:18 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
mlxsw, netdev, linux-kernel, linux-hardening
On Mon, May 15, 2023 at 01:22:48PM -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated and we are moving towards adopting
> C99 flexible-array members, instead. So, replace zero-length arrays
> declarations alone in structs with the new DECLARE_FLEX_ARRAY()
> helper macro.
>
> This helper allows for flexible-array members alone in structs.
>
> Link: https://github.com/KSPP/linux/issues/193
> Link: https://github.com/KSPP/linux/issues/285
> Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-16 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-15 19:22 [PATCH][next] mlxfw: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Gustavo A. R. Silva
2023-05-16 7:23 ` Ido Schimmel
2023-05-16 18:18 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).