From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Len Baker <len.baker@gmx.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Kees Cook <keescook@chromium.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mario Kleiner <mario.kleiner.de@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Randy Wright <rwright@hpe.com>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Tobias Diedrich <tobiasdiedrich@gmail.com>,
YueHaibing <yuehaibing@huawei.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-hardening@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250_pci: Prefer struct_size over open coded arithmetic
Date: Sun, 5 Sep 2021 19:13:54 +0300 [thread overview]
Message-ID: <CAHp75VcqTf3qef76nAE_TN32MdcvtYxZP2O8Oekap-_34mey0A@mail.gmail.com> (raw)
In-Reply-To: <20210905155728.11147-1-len.baker@gmx.com>
On Sun, Sep 5, 2021 at 6:58 PM Len Baker <len.baker@gmx.com> wrote:
>
> As noted in the "Deprecated Interfaces, Language Features, Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or similar)
> function arguments due to the risk of them overflowing. This could lead
> to values wrapping around and a smaller allocation being made than the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, use the struct_size() helper to do the arithmetic instead of the
> argument "size + size * count" in the kzalloc() function.
Makes sense
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
>
> Signed-off-by: Len Baker <len.baker@gmx.com>
> ---
> drivers/tty/serial/8250/8250_pci.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index a808c283883e..b97ade35d4a3 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -3981,9 +3981,7 @@ pciserial_init_ports(struct pci_dev *dev, const struct pciserial_board *board)
> nr_ports = rc;
> }
>
> - priv = kzalloc(sizeof(struct serial_private) +
> - sizeof(unsigned int) * nr_ports,
> - GFP_KERNEL);
> + priv = kzalloc(struct_size(priv, line, nr_ports), GFP_KERNEL);
> if (!priv) {
> priv = ERR_PTR(-ENOMEM);
> goto err_deinit;
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-09-05 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 15:57 [PATCH] serial: 8250_pci: Prefer struct_size over open coded arithmetic Len Baker
2021-09-05 16:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcqTf3qef76nAE_TN32MdcvtYxZP2O8Oekap-_34mey0A@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christian.gmeiner@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=keescook@chromium.org \
--cc=len.baker@gmx.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=mario.kleiner.de@gmail.com \
--cc=rwright@hpe.com \
--cc=tobiasdiedrich@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).