* [PATCH] hexagon: select FRAME_POINTER instead of redefining it
@ 2024-02-15 14:07 Masahiro Yamada
2024-02-15 17:03 ` Randy Dunlap
2024-02-15 19:12 ` Brian Cain
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2024-02-15 14:07 UTC (permalink / raw)
To: linux-kbuild; +Cc: Masahiro Yamada, Brian Cain, linux-hexagon, linux-kernel
Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
should select it.
Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS must
also be selected to avoid the unmet dependency warning.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/hexagon/Kconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
index a880ee067d2e..e922026fef09 100644
--- a/arch/hexagon/Kconfig
+++ b/arch/hexagon/Kconfig
@@ -7,7 +7,9 @@ config HEXAGON
select ARCH_32BIT_OFF_T
select ARCH_HAS_SYNC_DMA_FOR_DEVICE
select ARCH_NO_PREEMPT
+ select ARCH_WANT_FRAME_POINTERS
select DMA_GLOBAL_POOL
+ select FRAME_POINTER
# Other pending projects/to-do items.
# select HAVE_REGS_AND_STACK_ACCESS_API
# select HAVE_HW_BREAKPOINT if PERF_EVENTS
@@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET
help
Platforms that don't load the kernel at zero set this.
-config FRAME_POINTER
- def_bool y
-
config LOCKDEP_SUPPORT
def_bool y
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
2024-02-15 14:07 [PATCH] hexagon: select FRAME_POINTER instead of redefining it Masahiro Yamada
@ 2024-02-15 17:03 ` Randy Dunlap
2024-02-15 19:12 ` Brian Cain
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2024-02-15 17:03 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild; +Cc: Brian Cain, linux-hexagon, linux-kernel
On 2/15/24 06:07, Masahiro Yamada wrote:
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>
> Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS must
> also be selected to avoid the unmet dependency warning.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
>
> arch/hexagon/Kconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index a880ee067d2e..e922026fef09 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -7,7 +7,9 @@ config HEXAGON
> select ARCH_32BIT_OFF_T
> select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_NO_PREEMPT
> + select ARCH_WANT_FRAME_POINTERS
> select DMA_GLOBAL_POOL
> + select FRAME_POINTER
> # Other pending projects/to-do items.
> # select HAVE_REGS_AND_STACK_ACCESS_API
> # select HAVE_HW_BREAKPOINT if PERF_EVENTS
> @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET
> help
> Platforms that don't load the kernel at zero set this.
>
> -config FRAME_POINTER
> - def_bool y
> -
> config LOCKDEP_SUPPORT
> def_bool y
>
--
#Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
2024-02-15 14:07 [PATCH] hexagon: select FRAME_POINTER instead of redefining it Masahiro Yamada
2024-02-15 17:03 ` Randy Dunlap
@ 2024-02-15 19:12 ` Brian Cain
1 sibling, 0 replies; 3+ messages in thread
From: Brian Cain @ 2024-02-15 19:12 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild; +Cc: linux-hexagon, linux-kernel
> -----Original Message-----
> From: Masahiro Yamada <masahiroy@kernel.org>
> Sent: Thursday, February 15, 2024 8:07 AM
> To: linux-kbuild@vger.kernel.org
> Cc: Masahiro Yamada <masahiroy@kernel.org>; Brian Cain
> <bcain@quicinc.com>; linux-hexagon@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH] hexagon: select FRAME_POINTER instead of redefining it
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>
> Add 'select FRAME_POINTER' to HEXAGON. ARCH_WANT_FRAME_POINTERS
> must
> also be selected to avoid the unmet dependency warning.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/hexagon/Kconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index a880ee067d2e..e922026fef09 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -7,7 +7,9 @@ config HEXAGON
> select ARCH_32BIT_OFF_T
> select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> select ARCH_NO_PREEMPT
> + select ARCH_WANT_FRAME_POINTERS
> select DMA_GLOBAL_POOL
> + select FRAME_POINTER
> # Other pending projects/to-do items.
> # select HAVE_REGS_AND_STACK_ACCESS_API
> # select HAVE_HW_BREAKPOINT if PERF_EVENTS
> @@ -43,9 +45,6 @@ config HEXAGON_PHYS_OFFSET
> help
> Platforms that don't load the kernel at zero set this.
>
> -config FRAME_POINTER
> - def_bool y
> -
> config LOCKDEP_SUPPORT
> def_bool y
>
> --
> 2.40.1
Acked-by: Brian Cain <bcain@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-15 19:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 14:07 [PATCH] hexagon: select FRAME_POINTER instead of redefining it Masahiro Yamada
2024-02-15 17:03 ` Randy Dunlap
2024-02-15 19:12 ` Brian Cain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).