From: Clemens Ladisch <clemens@ladisch.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (k10temp) Add support for family 17h
Date: Tue, 5 Sep 2017 08:47:28 +0200 [thread overview]
Message-ID: <0565cf17-62d9-e319-8fe5-fbdf2d69335a@ladisch.de> (raw)
In-Reply-To: <1504575935-19476-1-git-send-email-linux@roeck-us.net>
Guenter Roeck wrote:
> Add support for temperature sensors on Family 17h (Ryzen) processors.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Some of this is guesswork, but afaics it is working. No idea if there
> is a better way to determine the temperature offset.
The reported value is not an absolute temperature on any CPU.
As far as I know, the offset is not guaranteed to be fixed for any model,
i.e., it would be pointless to apply the offset observed on one specific
chip.
> @@ -25,6 +25,10 @@
> #include <linux/pci.h>
> #include <asm/processor.h>
>
> +#ifndef PCI_DEVICE_ID_AMD_17H_DF_F3
> +#define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463
> +#endif
> +
Please move this down to the other symbols.
Regards,
Clemens
next prev parent reply other threads:[~2017-09-05 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 1:45 [PATCH] hwmon: (k10temp) Add support for family 17h Guenter Roeck
2017-09-05 6:47 ` Clemens Ladisch [this message]
2017-09-05 13:35 ` Guenter Roeck
2017-09-05 14:12 ` Clemens Ladisch
2017-09-05 16:45 ` Guenter Roeck
2017-09-05 17:48 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0565cf17-62d9-e319-8fe5-fbdf2d69335a@ladisch.de \
--to=clemens@ladisch.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).