From: Clemens Ladisch <clemens@ladisch.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (k10temp) Add support for family 17h
Date: Tue, 5 Sep 2017 19:48:56 +0200 [thread overview]
Message-ID: <9d0daec3-9850-4e36-7fdf-414c6f3beac1@ladisch.de> (raw)
In-Reply-To: <20170905164503.GA11478@roeck-us.net>
Guenter Roeck wrote:
> On Tue, Sep 05, 2017 at 04:12:07PM +0200, Clemens Ladisch wrote:
>> Guenter Roeck wrote:
>>> What we should do then, as we did for coretemp, would be to collect the various
>>> temperature offsets (and temperature limits, for that matter) and apply per-CPU
>>> adjustments. Are the offsets documented somewhere ?
>>
>> AMD says:
>> "Tctl is the processor temperature control value, used by the platform to
>> control cooling systems. Tctl is a non-physical temperature on an
>> arbitrary scale measured in degrees. It does _not_ represent an actual
>> physical temperature like die or case temperature. Instead, it specifies
>> the processor temperature relative to the point at which the system must
>> supply the maximum cooling for the processor's specified maximum case
>> temperature and maximum thermal power dissipation."
>
> Pretty much the same as Intel. That doesn't mean we should not (try to) report
> the real temperature as good as we can, as at least most of the BIOSes do,
AFAIK the BIOSes use the thermal diode (with external circuitry) for that.
> and as all the Windows tools do, and as users expect us to do.
>
> Do we really have to argue about this ?
Looking at coretemp, this is going to be a maintenance nightmare.
Oh well. If you insist, please add a proper chip-to-offset database, and
apply the offset to all four values.
Regards,
Clemens
prev parent reply other threads:[~2017-09-05 17:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 1:45 [PATCH] hwmon: (k10temp) Add support for family 17h Guenter Roeck
2017-09-05 6:47 ` Clemens Ladisch
2017-09-05 13:35 ` Guenter Roeck
2017-09-05 14:12 ` Clemens Ladisch
2017-09-05 16:45 ` Guenter Roeck
2017-09-05 17:48 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d0daec3-9850-4e36-7fdf-414c6f3beac1@ladisch.de \
--to=clemens@ladisch.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).