From: Armin Wolf <W_Armin@gmx.de>
To: Guenter Roeck <linux@roeck-us.net>, Hans de Goede <hdegoede@redhat.com>
Cc: markgross@kernel.org, jdelvare@suse.com,
platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: dell-ddv: Add hwmon support
Date: Mon, 6 Feb 2023 22:19:47 +0100 [thread overview]
Message-ID: <08af724c-8c65-db41-ece8-f330f67a3dc2@gmx.de> (raw)
In-Reply-To: <20230206162303.GA195090@roeck-us.net>
Am 06.02.23 um 17:23 schrieb Guenter Roeck:
> On Mon, Feb 06, 2023 at 03:13:25PM +0100, Hans de Goede wrote:
>> Hi Armin,
>>
>> On 2/5/23 21:54, Armin Wolf wrote:
>>> Thanks to bugreport 216655 on bugzilla triggered by the
>>> dell-smm-hwmon driver, the contents of the sensor buffers
>>> could be almost completely decoded.
>>> Add an hwmon interface for exposing the fan and thermal
>>> sensor values. Since the WMI interface can be quite slow
>>> on some machines, the sensor buffers are cached for 1 second
>>> to lessen the performance impact.
>>> The debugfs interface remains in place to aid in reverse-engineering
>>> of unknown sensor types and the thermal buffer.
>>>
>>> Tested-by: Antonín Skala <skala.antonin@gmail.com>
>>> Tested-by: Gustavo Walbon <gustavowalbon@gmail.com>
>>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>> This looks nice and clean to me, thank you:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> I'm going to wait a bit with merging this to see if Guenter
>> has any remarks. If there are no remarks by next Monday then
>> I'll merge this for the 6.3 merge window.
>>
> I don't have any further remarks. I won't send an Ack, though.
> I noticed that the empty lines before return statements distract
> me sufficiently enough that I am not sure about the actual code.
>
> Guenter
I will send a 3rd revision of the patch series to remove those empty lines then.
Speaking of a 3rd revision, i noticed that jiffies are not updated during suspend,
so the sensor values might be wrong for a short time when resuming after a long time.
This can be solved by either usingktime_get_boottime_ns(), which does not stop during suspend, or by
invalidating the sensor cache upon resume. Which method should be used
in this case? Armin Wolf
next prev parent reply other threads:[~2023-02-06 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 20:54 [PATCH 0/2] platform/x86: dell-ddv: Various driver updates Armin Wolf
2023-02-05 20:54 ` [PATCH 1/2] platform/x86: dell-ddv: Add hwmon support Armin Wolf
2023-02-06 14:13 ` Hans de Goede
2023-02-06 16:23 ` Guenter Roeck
2023-02-06 21:19 ` Armin Wolf [this message]
2023-02-06 22:11 ` Guenter Roeck
2023-02-05 20:54 ` [PATCH 2/2] platform/x86: dell-ddv: Prefer asynchronous probing Armin Wolf
2023-02-06 14:13 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08af724c-8c65-db41-ece8-f330f67a3dc2@gmx.de \
--to=w_armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).