From: Hans de Goede <hdegoede@redhat.com>
To: Armin Wolf <W_Armin@gmx.de>, markgross@kernel.org
Cc: jdelvare@suse.com, linux@roeck-us.net,
platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] platform/x86: dell-ddv: Prefer asynchronous probing
Date: Mon, 6 Feb 2023 15:13:21 +0100 [thread overview]
Message-ID: <296c2403-9ba3-f070-c939-ec845c7410a1@redhat.com> (raw)
In-Reply-To: <20230205205456.2364-3-W_Armin@gmx.de>
Hi,
On 2/5/23 21:54, Armin Wolf wrote:
> During probe, both sensor buffers need to be queried to
> initialize the hwmon channels. This might be slow on some
> machines, causing a unnecessary delay during boot.
> Mark the driver with PROBE_PREFER_ASYNCHRONOUS so that it
> can be probed asynchronously.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/dell/dell-wmi-ddv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c
> index b7ac483eff12..cffbba5e2d9a 100644
> --- a/drivers/platform/x86/dell/dell-wmi-ddv.c
> +++ b/drivers/platform/x86/dell/dell-wmi-ddv.c
> @@ -10,6 +10,7 @@
> #include <linux/acpi.h>
> #include <linux/debugfs.h>
> #include <linux/device.h>
> +#include <linux/device/driver.h>
> #include <linux/dev_printk.h>
> #include <linux/errno.h>
> #include <linux/kconfig.h>
> @@ -872,6 +873,7 @@ MODULE_DEVICE_TABLE(wmi, dell_wmi_ddv_id_table);
> static struct wmi_driver dell_wmi_ddv_driver = {
> .driver = {
> .name = DRIVER_NAME,
> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .id_table = dell_wmi_ddv_id_table,
> .probe = dell_wmi_ddv_probe,
> --
> 2.30.2
>
prev parent reply other threads:[~2023-02-06 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 20:54 [PATCH 0/2] platform/x86: dell-ddv: Various driver updates Armin Wolf
2023-02-05 20:54 ` [PATCH 1/2] platform/x86: dell-ddv: Add hwmon support Armin Wolf
2023-02-06 14:13 ` Hans de Goede
2023-02-06 16:23 ` Guenter Roeck
2023-02-06 21:19 ` Armin Wolf
2023-02-06 22:11 ` Guenter Roeck
2023-02-05 20:54 ` [PATCH 2/2] platform/x86: dell-ddv: Prefer asynchronous probing Armin Wolf
2023-02-06 14:13 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=296c2403-9ba3-f070-c939-ec845c7410a1@redhat.com \
--to=hdegoede@redhat.com \
--cc=W_Armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).