* [PATCH -next] platform/x86: asus-wmi: change kbd_rgb_mode_groups to static
@ 2022-09-13 13:54 Yang Yingliang
2022-09-17 11:43 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-09-13 13:54 UTC (permalink / raw)
To: linux-hwmon, platform-driver-x86, acpi4asus-user; +Cc: corentin.chary, hdegoede
kbd_rgb_mode_groups is only used in asus-wmi.c now, change it
to static.
Fixes: e305a71cea37 ("platform/x86: asus-wmi: Implement TUF laptop keyboard LED modes")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/platform/x86/asus-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index d95170b7dba0..ae46af731de9 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -835,7 +835,7 @@ static const struct attribute_group kbd_rgb_state_group = {
.attrs = kbd_rgb_state_attrs,
};
-const struct attribute_group *kbd_rgb_mode_groups[] = {
+static const struct attribute_group *kbd_rgb_mode_groups[] = {
NULL,
NULL,
NULL,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] platform/x86: asus-wmi: change kbd_rgb_mode_groups to static
2022-09-13 13:54 [PATCH -next] platform/x86: asus-wmi: change kbd_rgb_mode_groups to static Yang Yingliang
@ 2022-09-17 11:43 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-09-17 11:43 UTC (permalink / raw)
To: Yang Yingliang, linux-hwmon, platform-driver-x86, acpi4asus-user
Cc: corentin.chary
Hi,
On 9/13/22 15:54, Yang Yingliang wrote:
> kbd_rgb_mode_groups is only used in asus-wmi.c now, change it
> to static.
>
> Fixes: e305a71cea37 ("platform/x86: asus-wmi: Implement TUF laptop keyboard LED modes")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Thank you for your patch. This has already been fixed in my review-hans
branchm, so I am going to drop this patch.
Regards,
Hans
> ---
> drivers/platform/x86/asus-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index d95170b7dba0..ae46af731de9 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -835,7 +835,7 @@ static const struct attribute_group kbd_rgb_state_group = {
> .attrs = kbd_rgb_state_attrs,
> };
>
> -const struct attribute_group *kbd_rgb_mode_groups[] = {
> +static const struct attribute_group *kbd_rgb_mode_groups[] = {
> NULL,
> NULL,
> NULL,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-17 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 13:54 [PATCH -next] platform/x86: asus-wmi: change kbd_rgb_mode_groups to static Yang Yingliang
2022-09-17 11:43 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).