From: Svyatoslav Ryhel <clamor95@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: ina2xx: add supply property
Date: Wed, 08 Mar 2023 16:01:44 +0200 [thread overview]
Message-ID: <135993BF-B4AC-42C1-AD36-94F66EE1620D@gmail.com> (raw)
In-Reply-To: <5cd6764c-9b04-42ea-932d-9f14aa465605@sirena.org.uk>
8 березня 2023 р. 15:46:52 GMT+02:00, Mark Brown <broonie@kernel.org> написав(-ла):
>On Wed, Mar 08, 2023 at 02:58:20PM +0200, Svyatoslav Ryhel wrote:
>> 8 березня 2023 р. 14:54:34 GMT+02:00, Mark Brown <broonie@kernel.org> написав(-ла):
>> >On Wed, Mar 08, 2023 at 11:40:23AM +0200, Svyatoslav Ryhel wrote:
>> >> Add supply property.
>
>> >> + vdd-supply: true
>> >> +
>> >> required:
>> >> - compatible
>> >> - reg
>
>> >Unless the device can work without power the supply should be required.
>
>> Device can work without supply defined on most devices, but in my case power is gated with gpio and devices will not work without fixed regulator.
>
>If there are devices that work without any source of power at all that
>would be very surprising. It doesn't matter if a particular system has
>a non-controllable regulator, the binding should still make it mandatory
>to describe that.
Then question is WHY and WHO passed driver without power supply system implemented? Why it pops only now?
next prev parent reply other threads:[~2023-03-08 14:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:40 [PATCH v1 0/2] Add optional power supply for INA2XX Svyatoslav Ryhel
2023-03-08 9:40 ` [PATCH v1 1/2] dt-bindings: hwmon: ina2xx: add supply property Svyatoslav Ryhel
2023-03-08 10:27 ` Krzysztof Kozlowski
2023-03-08 10:32 ` Svyatoslav Ryhel
2023-03-08 10:36 ` Krzysztof Kozlowski
2023-03-08 11:35 ` Guenter Roeck
2023-03-08 11:54 ` Svyatoslav Ryhel
2023-03-08 12:54 ` Mark Brown
2023-03-08 12:58 ` Svyatoslav Ryhel
2023-03-08 13:13 ` Krzysztof Kozlowski
2023-03-08 13:46 ` Mark Brown
2023-03-08 14:01 ` Svyatoslav Ryhel [this message]
2023-03-08 14:37 ` Krzysztof Kozlowski
2023-03-08 14:38 ` Mark Brown
2023-03-08 9:40 ` [PATCH v1 2/2] hwmon: ina2xx: add optional regulator support Svyatoslav Ryhel
2023-03-08 10:25 ` Krzysztof Kozlowski
2023-03-08 10:35 ` Svyatoslav Ryhel
2023-03-08 10:37 ` Krzysztof Kozlowski
2023-03-08 11:13 ` Guenter Roeck
2023-03-08 11:19 ` Svyatoslav Ryhel
2023-03-08 11:32 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=135993BF-B4AC-42C1-AD36-94F66EE1620D@gmail.com \
--to=clamor95@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).