From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: ina2xx: add supply property
Date: Wed, 8 Mar 2023 11:36:29 +0100 [thread overview]
Message-ID: <52f951e6-1b14-1a47-0a62-4203978be024@linaro.org> (raw)
In-Reply-To: <CAPVz0n38LtyAqBP4GfC003xzaW78FaZ91zjdTNe46ormL5RY=Q@mail.gmail.com>
On 08/03/2023 11:32, Svyatoslav Ryhel wrote:
> ср, 8 бер. 2023 р. о 12:27 Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> пише:
>>
>> On 08/03/2023 10:40, Svyatoslav Ryhel wrote:
>>> Add supply property.
>>
>> You have entire commit msg to explain and give background, but instead
>> there is just sentence duplicating subject. And since you did not
>> explain anything, we have questions... like: INA238 does not have VDD,
>> so this does not look correct.
>>
>
> This is why a regulator is not mandatory. If ina238 does not have vdd
> then one who needs ina238 may omit this prop. How about looking from
> this perspective?
Not required means "optional", not "not existing" or "totally invalid".
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 10:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:40 [PATCH v1 0/2] Add optional power supply for INA2XX Svyatoslav Ryhel
2023-03-08 9:40 ` [PATCH v1 1/2] dt-bindings: hwmon: ina2xx: add supply property Svyatoslav Ryhel
2023-03-08 10:27 ` Krzysztof Kozlowski
2023-03-08 10:32 ` Svyatoslav Ryhel
2023-03-08 10:36 ` Krzysztof Kozlowski [this message]
2023-03-08 11:35 ` Guenter Roeck
2023-03-08 11:54 ` Svyatoslav Ryhel
2023-03-08 12:54 ` Mark Brown
2023-03-08 12:58 ` Svyatoslav Ryhel
2023-03-08 13:13 ` Krzysztof Kozlowski
2023-03-08 13:46 ` Mark Brown
2023-03-08 14:01 ` Svyatoslav Ryhel
2023-03-08 14:37 ` Krzysztof Kozlowski
2023-03-08 14:38 ` Mark Brown
2023-03-08 9:40 ` [PATCH v1 2/2] hwmon: ina2xx: add optional regulator support Svyatoslav Ryhel
2023-03-08 10:25 ` Krzysztof Kozlowski
2023-03-08 10:35 ` Svyatoslav Ryhel
2023-03-08 10:37 ` Krzysztof Kozlowski
2023-03-08 11:13 ` Guenter Roeck
2023-03-08 11:19 ` Svyatoslav Ryhel
2023-03-08 11:32 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f951e6-1b14-1a47-0a62-4203978be024@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).