* [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells
@ 2018-11-07 15:47 Heiko Stuebner
2018-11-07 18:39 ` Guenter Roeck
[not found] ` <5bea0ecc.1c69fb81.e2af6.29c7@mx.google.com>
0 siblings, 2 replies; 5+ messages in thread
From: Heiko Stuebner @ 2018-11-07 15:47 UTC (permalink / raw)
To: jdelvare, linux, robh+dt, mark.rutland
Cc: linux-hwmon, devicetree, linux-kernel, heiko, Heiko Stuebner
From: Heiko Stuebner <heiko.stuebner@bq.com>
The tmp108 does have an alert output that can be used as interrupt source
and can of course also be used as part of a thermal sensor setup for things
like thermal-based cpu frequencies, so document the necessary properties.
Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
---
Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt
index 8c4b10df86d9..54d4beed4ee5 100644
--- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
+++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt
@@ -7,6 +7,10 @@ Requires node properties:
- compatible : "ti,tmp108"
- reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
+Optional properties:
+- interrupts: Reference to the TMP108 alert interrupt.
+- #thermal-sensor-cells: should be set to 0.
+
Example:
tmp108@48 {
compatible = "ti,tmp108";
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells
2018-11-07 15:47 [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells Heiko Stuebner
@ 2018-11-07 18:39 ` Guenter Roeck
2018-11-07 21:33 ` Heiko Stübner
[not found] ` <5bea0ecc.1c69fb81.e2af6.29c7@mx.google.com>
1 sibling, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2018-11-07 18:39 UTC (permalink / raw)
To: Heiko Stuebner
Cc: jdelvare, robh+dt, mark.rutland, linux-hwmon, devicetree,
linux-kernel, Heiko Stuebner
Hi,
On Wed, Nov 07, 2018 at 04:47:08PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@bq.com>
>
> The tmp108 does have an alert output that can be used as interrupt source
> and can of course also be used as part of a thermal sensor setup for things
> like thermal-based cpu frequencies, so document the necessary properties.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
Do you also plan to actually implement interrupt support in the driver ?
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> index 8c4b10df86d9..54d4beed4ee5 100644
> --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> @@ -7,6 +7,10 @@ Requires node properties:
> - compatible : "ti,tmp108"
> - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
>
> +Optional properties:
> +- interrupts: Reference to the TMP108 alert interrupt.
> +- #thermal-sensor-cells: should be set to 0.
> +
> Example:
> tmp108@48 {
> compatible = "ti,tmp108";
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells
2018-11-07 18:39 ` Guenter Roeck
@ 2018-11-07 21:33 ` Heiko Stübner
2018-11-07 21:38 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Heiko Stübner @ 2018-11-07 21:33 UTC (permalink / raw)
To: Guenter Roeck
Cc: jdelvare, robh+dt, mark.rutland, linux-hwmon, devicetree, linux-kernel
Hi Guenter,
Am Mittwoch, 7. November 2018, 19:39:58 CET schrieb Guenter Roeck:
> On Wed, Nov 07, 2018 at 04:47:08PM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@bq.com>
> >
> > The tmp108 does have an alert output that can be used as interrupt source
> > and can of course also be used as part of a thermal sensor setup for
> > things
> > like thermal-based cpu frequencies, so document the necessary properties.
> >
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
>
> Do you also plan to actually implement interrupt support in the driver ?
Not right now but I'm hoping down the road.
The main argument for including this standard property is that
the dt-binding is of course a description of the hardware and not the
state of the linux driver and the tmp108 obviously has that alert output
pin, hence I'd really like to already have it in the new board-dts I'm
currently working on so it simply magically works once the driver can
use it :-) .
Heiko
> > ---
> >
> > Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> > b/Documentation/devicetree/bindings/hwmon/tmp108.txt index
> > 8c4b10df86d9..54d4beed4ee5 100644
> > --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> > +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> >
> > @@ -7,6 +7,10 @@ Requires node properties:
> > - compatible : "ti,tmp108"
> > - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
> >
> > +Optional properties:
> > +- interrupts: Reference to the TMP108 alert interrupt.
> > +- #thermal-sensor-cells: should be set to 0.
> > +
> >
> > Example:
> > tmp108@48 {
> >
> > compatible = "ti,tmp108";
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells
2018-11-07 21:33 ` Heiko Stübner
@ 2018-11-07 21:38 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2018-11-07 21:38 UTC (permalink / raw)
To: Heiko Stübner
Cc: jdelvare, robh+dt, mark.rutland, linux-hwmon, devicetree, linux-kernel
On Wed, Nov 07, 2018 at 10:33:12PM +0100, Heiko Stübner wrote:
> Hi Guenter,
>
> Am Mittwoch, 7. November 2018, 19:39:58 CET schrieb Guenter Roeck:
> > On Wed, Nov 07, 2018 at 04:47:08PM +0100, Heiko Stuebner wrote:
> > > From: Heiko Stuebner <heiko.stuebner@bq.com>
> > >
> > > The tmp108 does have an alert output that can be used as interrupt source
> > > and can of course also be used as part of a thermal sensor setup for
> > > things
> > > like thermal-based cpu frequencies, so document the necessary properties.
> > >
> > > Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
> >
> > Do you also plan to actually implement interrupt support in the driver ?
>
> Not right now but I'm hoping down the road.
>
> The main argument for including this standard property is that
> the dt-binding is of course a description of the hardware and not the
> state of the linux driver and the tmp108 obviously has that alert output
> pin, hence I'd really like to already have it in the new board-dts I'm
> currently working on so it simply magically works once the driver can
> use it :-) .
>
NP, just asking. Let's wait for Rob's review, then I'll apply the patch
unless he has issues.
Thanks,
Guenter
>
> Heiko
>
> > > ---
> > >
> > > Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> > > b/Documentation/devicetree/bindings/hwmon/tmp108.txt index
> > > 8c4b10df86d9..54d4beed4ee5 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> > > +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> > >
> > > @@ -7,6 +7,10 @@ Requires node properties:
> > > - compatible : "ti,tmp108"
> > > - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
> > >
> > > +Optional properties:
> > > +- interrupts: Reference to the TMP108 alert interrupt.
> > > +- #thermal-sensor-cells: should be set to 0.
> > > +
> > >
> > > Example:
> > > tmp108@48 {
> > >
> > > compatible = "ti,tmp108";
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <5bea0ecc.1c69fb81.e2af6.29c7@mx.google.com>]
* Re: [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells
[not found] ` <5bea0ecc.1c69fb81.e2af6.29c7@mx.google.com>
@ 2018-11-13 17:32 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2018-11-13 17:32 UTC (permalink / raw)
To: Rob Herring
Cc: Heiko Stuebner, jdelvare, robh+dt, mark.rutland, linux-hwmon,
devicetree, linux-kernel, Heiko Stuebner
On Mon, Nov 12, 2018 at 05:37:46PM -0600, Rob Herring wrote:
> On Wed, 7 Nov 2018 16:47:08 +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@bq.com>
> >
> > The tmp108 does have an alert output that can be used as interrupt source
> > and can of course also be used as part of a thermal sensor setup for things
> > like thermal-based cpu frequencies, so document the necessary properties.
> >
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com>
> > ---
> > Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
Applied to hwmon-next.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-14 3:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 15:47 [PATCH] dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells Heiko Stuebner
2018-11-07 18:39 ` Guenter Roeck
2018-11-07 21:33 ` Heiko Stübner
2018-11-07 21:38 ` Guenter Roeck
[not found] ` <5bea0ecc.1c69fb81.e2af6.29c7@mx.google.com>
2018-11-13 17:32 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).